Repository navigation
feat: rebuild the Share Extension with SwiftUI - #4430
Draft
marinofaggiana wants to merge 14 commits into
Draft
marinofaggiana wants to merge 14 commits into
marinofaggiana wants to merge 14 commits into
Conversation
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Host Share sources in app Debug builds with SHARE_PREVIEWS and exclude them from Release builds. Gate preview code and document the required scheme. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Persist the last three successful upload destinations per account and validate folders before selection. Add unit tests for recent destination storage. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Require server capabilities before browsing or uploading, with loading states and retry support. Fall back to usable text when other shared representations fail, including attributed text, and add import regression tests. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Centralize account readiness checks and pass capabilities explicitly through upload preparation and staging. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Distinguish recent-folder selection from tree selection, streamline the folder and file lists, and show a pluralized file count on the upload button. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Refresh folders asynchronously and consolidate share status indicators into a single prioritized view. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Replace the account picker sheet with a menu showing avatars and account aliases. Add cached Quick Look thumbnails with file-type icon fallbacks, and enlarge file and folder rows. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Block network actions while offline and retry loading on reconnect. Adapt the Share extension to compact landscape layouts and show loading progress beside the account menu. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Place the folder header and upload button across both columns, let the file list fill available height, and round selected folder highlights. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Add an explicit cancel action and refine folder label colors and selection padding. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Show favorite folders first with accessible star badges, and scale file thumbnails to fill their frames. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
marinofaggiana
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the legacy Share Extension with a new SwiftUI interface and revised input preparation, account selection, and upload conflict handling.
Adds unit tests for input loading, conflict naming, and recent destinations. Device testing and broader validation are still ongoing.
🤖 AI