[antoinetran]

Description of the change

Regression from my patch #187 . The issue is that I missed a volumeMount inside nextcloud container so that the redis ini config is missing. Also fixed a small indentation typo.

Benefits

Possible drawbacks

I tested manually my patch by modifying the deployment yaml of nextcloud and adding the volumeMount.

Applicable issues

• fixes External Redis not working: redis-session.ini: Permission denied #883

Additional information

Checklist

• I have read the CONTRIBUTING.md doc.
• DCO has been signed off on the commit.
• Chart version bumped in Chart.yaml according to semver.
• (optional) Parameters are documented in the README.md

[keliansb]

Can someone review this PR please? Installations with external Redis are all broken since v9.2.3 without this fix.

[keliansb]

@antoinetran shouldn't you change {{- if $.Values.redis.enabled }} to {{- if or $.Values.redis.enabled $.Values.externalRedis.enabled }} to also support external Redis?

[antoinetran]

@antoinetran shouldn't you change {{- if $.Values.redis.enabled }} to {{- if or $.Values.redis.enabled $.Values.externalRedis.enabled }} to also support external Redis?

Good point, indeed with externalRedis.enabled: true the host and port is also exposed as env var. Done.

[antoinetran]

@maintainers of nextcloud helm: can we have a review here please? The regression is difficult to workaround and the fix is simple. Thanks!

[antoinetran]

I just rebased on main and and squashed.

[antoinetran]

ping @wrenix

[RisingOpsNinja]

@antoinetran you need to sign all commits and add a Signed-off-by line in the commit messages

https://github.com/nextcloud/helm/pull/886/checks?check_run_id=114814224612
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

[antoinetran]

@antoinetran you need to sign all commits and add a Signed-off-by line in the commit messages

https://github.com/nextcloud/helm/pull/886/checks?check_run_id=114814224612 https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Oups, during rebase to main, I must have forgotten. I did it just now, rebased to main again, and force pushed.