Repository navigation
fix(teams): hide member actions the user is not allowed to perform - #5796
Merged
Merged
Conversation
kyteinsky
requested review from
GVodyanov,
SebastianKrupinski and
hamza221
as code owners
October 22, 2026 20:32
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
kyteinsky
force-pushed
the
fix/circles/2808
branch
from
October 22, 2026 21:04
59af864 to
cf0d45a
Compare
The member menu showed options that the server rejects: - With "Members can also invite" enabled, plain members saw "Remove member", but only moderators and above can remove members. - Moderators saw "Promote to Admin", but only admins can change promote members to admin. - Current user check compared the wrong ID which did not show the "Leave Team" button but showed a "Remove member" option which failed before. Signed-off-by: Anupam Kumar <kyteinsky@gmail.com> Assisted-by: Github Copilot:claude-opus-5-5
kyteinsky
force-pushed
the
fix/circles/2808
branch
from
October 22, 2026 21:05
cf0d45a to
3303b6d
Compare
cristianscheid
approved these changes
Oct 23, 2026
Contributor
|
/backport to stable8.9 |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The member menu showed options that the server rejected:
The changes have been ported from https://github.com/nextcloud/circles/pull/2659/changes#diff-9d7019613f51c3295ed2655f2ad6d8474e0b4e0da1a9d2e4f3afb5f4b686646c
Assisted-by: Github Copilot:claude-opus-5-5
fixes: nextcloud/circles#2808
now the page shows a "Leave Team" button only beside the user currently logged in:
🤖 AI (if applicable)