[Luctia]

This PR is part of a three-PR implementation of #5245 and nextcloud/recognize#1285. It also largely addresses nextcloud/recognize#498 (contact photos do not seed clustering in this PR) and nextcloud/recognize#1412 (recognize gets no relation editor, but personally I'm not sure whether that is really the place for it anyway. Perhaps recognize could read out relations from contacts?).

Other PRs

• feat(faces): link people to contacts photos#4003
• Feat/link faces to contacts recognize#1580

🤖 AI (if applicable)

• The content of this PR was partly or fully generated using AI (N/A)

I created this code with Claude Fable 5.1. I am a developer, but not in PHP or Vue. I reviewed the code and played with the new features in a local instance, and I think everything looks good.

[hamza221]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Head commit changed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[hamza221]

Rebased to fix CI, No code change submitted

[coderabbitai]

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

tests/javascript/services/recognizeFaces.test.js

Oops! Something went wrong! :(

ESLint: 10.13.0

ReferenceError: module is not defined in ES module scope
This file is being treated as an ES module because it has a '.js' file extension and '/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
at file:///tests/.eslintrc.js?mtime=1792753688851:5:1
at ModuleJob.run (node:internal/modules/esm/module_job:561:25)
at async node:internal/modules/esm/loader:647:26
at async dynamicImportConfig (/.eslint-tmp/node_modules/.pnpm/eslint@10.13.0_supports-color@8.1.1/node_modules/eslint/lib/config/config-loader.js:185:17)
at async loadConfigFile (/.eslint-tmp/node_modules/.pnpm/eslint@10.13.0_supports-color@8.1.1/node_modules/eslint/lib/config/config-loader.js:275:9)
at async ConfigLoader.calculateConfigArray (/.eslint-tmp/node_modules/.pnpm/eslint@10.13.0_supports-color@8.1.1/node_modules/eslint/lib/config/config-loader.js:594:23)
at async #calculateConfigArray (/.eslint-tmp/node_modules/.pnpm/eslint@10.13.0_supports-color@8.1.1/node_modules/eslint/lib/config/config-loader.js:369:19)
at async Promise.all (index 0)
at async findFiles (/.eslint-tmp/node_modules/.pnpm/eslint@10.13.0_supports-color@8.1.1/node_modules/eslint/lib/eslint/eslint-helpers.js:637:25)
at async ESLint.lintFiles (/.eslint-tmp/node_modules/.pnpm/eslint@10.13.0_supports-color@8.1.1/node_modules/eslint/lib/eslint/eslint.js:1025:21)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 8.38323% with 153 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
.../components/ContactDetails/RecognizeFacePicker.vue	0.00%	100 Missing ⚠️
...components/ContactDetails/ContactDetailsAvatar.vue	0.00%	47 Missing ⚠️
src/services/recognizeFaces.js	70.00%	6 Missing ⚠️

📢 Thoughts on this report? Let us know!