Repository navigation
Conversation
119b397 to
f9afac7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
hamza221
left a comment
There was a problem hiding this comment.
Looks good, thank you for the fix, could you please update the commit message.
It's not a l10n fix, and then I will approve and merge
|
/backport to stable8.9 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Assisted-by: Cursor:grok-4.7 Signed-off-by: whoalin1 <whoalin414@gmail.com>
f9afac7 to
036b82d
Compare
|
/backport to stable8.9 |
|
Looked into the failing Root cause is unrelated to this PR's change (this PR only touches This run is from 2026-10-22. The same No code changes pushed, since there's nothing in this PR's diff to fix for this failure. |
Summary
#2399 asked for separate Transifex strings for the “New contact” button vs the name field default. Main already uses
New contacton the button andNameas the FN default / input label.missingFN.jsstill compared againstNew contact, so the “don’t auto-fix an untouched new-contact FN” branch never ran for contacts created with theNamedefault.Align the check with
t('contacts', 'Name').Closes #2399
Test plan
Nameand that has structured N: repair still builds FN from NAI disclosure
This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.
All commits carry an
Assisted-by: Cursor:grok-4.7trailer.