Repository navigation
Conversation
|
@mickenordin , @redblom , FYI :-) |
Signed-off-by: Tom Wezepoel <tom.wezepoel@surf.nl>
e5e7ee1 to
2888a2d
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@hamza221 , @SebastianKrupinski can you review this ? |
|
CI is related, could you please take a look at that |
hamza221
added
enhancement
|
@hamza221 @GVodyanov can you start the pipelines again for me to check if the unit tests now pass ? 😃 |
b5cbb89 to
d7761e6
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 2 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title identifies the main change: using Nextcloud's default mail template for invitation emails. The wording is slightly awkward, but it is specific and related to the changeset. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
d7761e6 to
478a4cf
Compare
Signed-off-by: Tom Wezepoel <tom.wezepoel@surf.nl>
Signed-off-by: Tom Wezepoel <tom.wezepoel@surf.nl>
…view Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Tom Wezepoel <tom.wezepoel@surf.nl>
… creation Signed-off-by: Roberto Guido <info@madbob.org> Signed-off-by: Tom Wezepoel <tom.wezepoel@surf.nl>
Signed-off-by: hamza <hamzamahjoubi221@gmail.com> Signed-off-by: Tom Wezepoel <tom.wezepoel@surf.nl>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Tom Wezepoel <tom.wezepoel@surf.nl>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Tom Wezepoel <tom.wezepoel@surf.nl>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Tom Wezepoel <tom.wezepoel@surf.nl>
478a4cf to
062cdca
Compare
|
Sorry, had some troubles with DCO, where I forgot the signoff on some commits. Hope that I have solved now everything. @hamza221 can you trigger the pipelines for me hopefully now really for the last time? 🙈 |
I did but the commits need to be cleaned up, maybe a rebase on top of main would fix it |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
7 participants
When an OCM invitation request is sent, it is currently a plaintext email. Since we will be exchanging data here and the outside world isn’t always trustworthy, we want to provide the user with some identifying features. It is therefore recommended to use the Nextcloud standard email template, which the user may already recognize from the service and which also displays the service’s logo, color, and name.
We are expanding the OCM invitation flow using the standard Nextcloud email template.
The email now uses Nextcloud core's standard
IEMailTemplate(same as sharebymail, IMipPlugin, NewUserMailHelper, etc.), so the branded header/footer, button styling, and light/dark-safe HTML come from core instead of hand-rolled<br>markup.🤖 AI (if applicable)
With use of Claude was this PR created
Summary by CodeRabbit