Skip to content

fix: import - #5386

Merged
SebastianKrupinski merged 1 commit into
mainfrom
fix/contacts-import
Oct 22, 2026
Merged

SebastianKrupinski merged 1 commit into
mainfrom
fix/contacts-import

Conversation

@SebastianKrupinski

@SebastianKrupinski SebastianKrupinski commented Jun 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

@codecov

codecov Bot commented Jun 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 22.01835% with 85 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ponents/AppNavigation/Settings/ImportScreenRow.vue 0.00% 59 Missing ⚠️
...components/AppNavigation/Settings/ImportScreen.vue 51.06% 23 Missing ⚠️
.../AppNavigation/Settings/SettingsImportContacts.vue 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@SebastianKrupinski
SebastianKrupinski marked this pull request as draft June 13, 2026 18:21
@SebastianKrupinski SebastianKrupinski added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 24, 2026
@SebastianKrupinski
SebastianKrupinski marked this pull request as ready for review June 24, 2026 19:32
Comment thread src/components/AppNavigation/Settings/ImportScreen.vue Outdated
Comment thread src/components/AppNavigation/Settings/ImportScreen.vue Outdated
Comment thread src/components/AppNavigation/Settings/ImportScreen.vue Outdated
Comment thread src/components/AppNavigation/Settings/SettingsImportContacts.vue Outdated
@GVodyanov

Copy link
Copy Markdown
Contributor
image

I can see the vision with the two columns but the weird padding that nc-vue ads makes it look not great. I would suggest stretching out the inputs to be full column width and adding a gap between the columns.

@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

Updated import status screen as per designs request

image

@jancborchardt

@GVodyanov GVodyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works!

@hamza221 hamza221 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have the import button enabled even when there's no writable addressbook

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

Would be nice to have the import button enabled even when there's no writable addressbook

Done

@SebastianKrupinski

SebastianKrupinski commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor Author

/backport to stable8.9

@SebastianKrupinski
SebastianKrupinski merged commit 5841fd3 into main Oct 22, 2026
40 of 45 checks passed
@SebastianKrupinski
SebastianKrupinski deleted the fix/contacts-import branch October 22, 2026 21:42
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Oct 22, 2026
@backportbot backportbot Bot mentioned this pull request Oct 22, 2026
@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

Bypassed the failed psalm tests as this PR is all front end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

4 participants