Repository navigation
feat(tasks): add Blocked task status with reason (#307) - #311
Merged
Merged
Conversation
- Show an "Add reason" prompt on Blocked rows with no reason (journal and task list) - Remove unused isOpen helper from task-status
nevridge
commented
Oct 22, 2026
nevridge
left a comment
Owner
Author
There was a problem hiding this comment.
Review: 💬 Comments
The PR adds the Blocked status end to end, with the transition rules enforced on the server and covered by tests. Two findings from review are fixed in e574da5, and nothing is left open.
| # | Severity | Location | Finding | Status |
|---|---|---|---|---|
| 1 | 🟠 Important | TaskFlow.Web/src/components/journal/TodosSection.tsx:359 |
A task blocked with an empty reason had no control to add a reason later (journal and task list) | ✅ Fixed in e574da5 |
| 2 | ⚪ Nit | TaskFlow.Web/src/lib/task-status.ts:57 |
isOpen was exported but unused outside its own test |
✅ Fixed in e574da5 |
Fixes pushed
Commit e574da5 addresses: [1], [2]
Reviewed at e574da5 · findings from pr-review + code-review, verified and triaged by @nevridge with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
Blockedtask status with an optional reason, so work waiting on something external is visibly separate from work that can be acted on today. Built on the PATCH endpoint and Status-only completion from #310.Closes #307
Backend
Status.Blocked = 3.TaskItemgainsBlockedReason(max 200, trimmed, blank stored as null),BlockedAt(UTC, serialized withZ) andPreviousStatus(set server-side only).AddTaskItemBlockedStatusadds three nullable columns with no backfill.Downmaps Blocked rows back toPreviousStatus ?? Todobefore dropping them, so the blocked data is lost on rollback.ApplyUpdateAsync(shared by PUT and PATCH):blockedReason: omitted keeps it, null or""clears it. PUT: null keeps it,""clears it. The difference is documented in the DTOs.Blocked,Unblocked,BlockedReasonChanged, and a singleCompletedevent for Blocked→Completed. Blocked transitions never writeStatusChanged.BlockedCounton projects (Blocked also stays inOpenTaskCount). The three response mapping sites emit the new fields.types.gen.tschanged, and it only gained fields.Frontend
src/lib/task-status.tsis the single source of truth for statuses.normalizeStatusis case-insensitive and renders unknown values raw, not as "Draft".TaskHistoryPanellabels, and "N open (M blocked) · K completed" counts.--danger-inkand--danger-bg. There is no--dangertoken, so no new token was added.throwOnError, so its existing error and rollback paths actually fire. This is a small fix beyond the story.Tests
TaskItemsControllerBlockedTests, migration up/down tests, repository event tests and carry-forward tests.type-check,buildanddotnet format --verify-no-changespass. Lint shows 0 errors and the pre-existingTasksPage.tsxuseMemowarning.Residual minor findings (awareness only)
TaskCard.tsxhas no Blocked treatment, but it is unused (only its own test imports it).Release notes
Blockedyet, solist_tasks,update_taskandweekly_reviewmay mishandle it until updated (nevridge/taskflow-assistant#12).