Repository navigation
fix(deps): bump MicrosoftPlatformVersion to 10.0.11 for SQLitePCLRaw advisory - #305
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
MicrosoftPlatformVersionfrom 10.0.8 to 10.0.11 inDirectory.Build.props.Microsoft.EntityFrameworkCore.Sqlite10.0.11 pullsSQLitePCLRaw2.1.12, which is outside the affected range (<= 2.1.11) of GHSA-2m69-gcr7-jv3q. That clears the high-severity NU1903 warning inTaskFlow.ApiandTaskFlow.Api.Tests.10.0.11 is the smallest 10.0.x patch that carries the fix. It was chosen over the latest patch (10.0.13) to avoid upgrading further than needed, and later patches are left to Dependabot.
Closes #302
Assessment (AC 1-2)
SQLitePCLRaw.lib.e_sqlite3<= 2.1.11. GitHub lists no first patched version, but 2.1.12 and later are outside the range.FromSql|ExecuteSql|SqlQuery|load_extension|EnableExtensions|fts5|CREATE VIRTUALoverTaskFlow.Api(excluding Migrations) found nothing. All SQL is EF-generated and parameterized, and the database is local and single-user.Microsoft.EntityFrameworkCore.Sqlite10.0.9 and 10.0.10 still pull 2.1.11. 10.0.11 and 10.0.12 pull 2.1.12, and 10.0.13 pulls 2.1.13.What changed
Directory.Build.props:MicrosoftPlatformVersion10.0.8 -> 10.0.11. This moves the whole platform group together (EF Core, Design/Tools, InMemory, Sqlite, andMicrosoft.AspNetCore.OpenApi, which includes the OpenAPI source generator).TaskFlow.Web, no compose files, Dockerfiles, workflows or Trivy config. No new direct package reference, so no extra comment is needed.Verification
dotnet build -c Release(incl.--no-incremental)dotnet list TaskFlow.sln package --vulnerable --include-transitiveSQLitePCLRaw.*(lib, bundle, core, provider)dotnet test --solution TaskFlow.sln:memory:SQLite and theSqliteException19 / 2067 checks)dotnet format TaskFlow.sln --verify-no-changesMicrosoft.OpenApipin (#279)Microsoft.AspNetCore.OpenApi10.0.11 requires[2.7.5, 3.0.0); the 2.7.5 pin satisfies it exactlyNot verified locally (please confirm in CI)
TaskFlow.Api/Dockerfilerestore. It failed locally with NU1301 (PartialChain) because of corporate TLS interception on the dev machine, unrelated to this change.Directory.Build.propsis already copied in that file, and theDockerfile.localrestore passed.security-scanrun onmainsucceeded and did not flag this advisory, so no Trivy config was changed.e_sqlite32.1.12. The SQLite-backed tests passed on it.Residual validator findings (Minor, informational, no action)
TaskFlow.Api.csprojmentions Tools 10.0.8; it describes a past defect and is still accurate. The Tools and Design packages both resolve at 10.0.11.Microsoft.OpenApi2.7.5 is now also the lower bound required byMicrosoft.AspNetCore.OpenApi10.0.11. The existing pin and the Dependabot major-version ignore stay valid.Directory.Build.propsunder.claude/worktreesstill says 10.0.8. It is not part of the branch.