Repository navigation
Test the revision and paper checkers' branches - #44
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins every check in
check_revision,check_paperandcheck_run(layouts.py) with a test that builds the failing case from the example corpus and run, and asserts the exact message. Tests only; I found no bug in the checker.Before this, removing the duplicate-key check (
_check_keys) or the more-than-one-verdict check left all 210 tests green (coverage analysis M5, M6). They also covered none of: original's parse_id, different article, different text, add already in original, add missing from revision, verdict for a key not in the original, replaced_by not in the revision, accept/relabel key not surviving, new analysis neither added nor a replacement,check_paperwrong kind / schema version / article mismatch / different text / corpus holding a revision / missing text_path, andcheck_runwith no record.Mutation check: each of 25 conditions in those functions replaced by
if False(or inverted/emptied), one at a time; each made at least one test fail, including the new test named for that check. None survived.Suite: full run on beast in a fresh venv (
.[test,generate,layouts,parquet]), all passing.🤖 Generated with Claude Code