Repository navigation
[FIX] High severity - #26
Merged
Merged
Conversation
GET query strings now send booleans as "true"/"false" instead of 1/0.
setVelocityPolicyRule, updateVelocityPolicyRule and removePolicyRule put the rule ID where the wallet ID belongs, so every call hit the wrong URL. Move the test reflection helpers into a shared trait.
10 ETH in wei is above PHP_INT_MAX, so int amounts overflowed. sendTransaction now takes an int or a string of digits, and sendTransactionToMany and buildTransaction send each recipient amount as a string. Add BitGoSDK::toBaseUnits() and fromBaseUnits() for exact conversion at any number of decimals. toSatoshi() and toBTC() now use them: toSatoshi() accepts strings and no longer breaks under locales with a decimal comma, and toBTC() no longer round-trips through a float. BCMath is no longer used, so ext-bcmath is no longer required.
Requests had no timeout and could hang forever. Both clients now default to a 10 second connect timeout and a request timeout of 60 seconds (BitGoSDK) or 310 seconds (BitGoExpress, just over Express's own 305 seconds). Change them with setTimeout() and setConnectTimeout(). A cURL failure, a non-2xx status or an invalid JSON body used to come back as null or as BitGo's raw error body. They now come back as ['error' => ..., 'status' => ...], keeping any other fields BitGo sent, so existing isset($r['error']) checks keep working. The status is 0 when the request never got a response. buildTransaction and signBuildTransaction return the same fields as an object.
It has had no effect since PHP 8.0, and on 7.4 the handle is freed when it goes out of scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.