Skip to content

[NAE-2487] Add Column Configuration and Sorting to Menu Item - #481

Open
SamuelPalaj wants to merge 1 commit into
release/7.1.0from
NAE-2487
Open

SamuelPalaj wants to merge 1 commit into
release/7.1.0from
NAE-2487

Conversation

@SamuelPalaj

@SamuelPalaj SamuelPalaj commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • added functionality to define which headers are selected for sorting by default
  • added sort direction field
    Implements NAE-2487

Test Configuration

Name Tested on
OS windows 10
Runtime java 21
Dependency Manager Maven 3.9.9
Framework version Spring Boot 3.4.4
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Summary by CodeRabbit

  • New Features
    • Added settings to choose which columns are sortable in tabbed case and task views.
    • Added a default sort direction setting, with descending selected by default.
    • Added Slovak and German labels and descriptions for the new settings.

- added functionality to define which headers are selected for sorting by default
- added sort direction field
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d632dd74-80d5-4886-a465-9e669716aa17

📥 Commits

Reviewing files that changed from the base of the PR and between dc7dd52 and 8916bac.


📒 Files selected for processing (6)
  • application-engine/src/main/resources/petriNets/engine-processes/menu/tabbed_case_view_configuration.xml
  • application-engine/src/main/resources/petriNets/engine-processes/menu/tabbed_task_view_configuration.xml
  • nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/menu/configurations/TabbedCaseViewBody.java
  • nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/menu/configurations/TabbedCaseViewConstants.java
  • nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/menu/configurations/TabbedTaskViewBody.java
  • nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/menu/configurations/TabbedTaskViewConstants.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



Walkthrough

Case and task tabbed views now configure active header sort columns and sort direction. Their body classes serialize the active columns as comma-separated text and the direction as an enumeration-map value. Both configurations default the direction to descending and include Slovak and German labels.

Changes

Tabbed view header sorting

Layer / File(s) Summary
Sort settings data contract
nae-object-library/.../TabbedCaseViewBody.java, nae-object-library/.../TabbedCaseViewConstants.java, nae-object-library/.../TabbedTaskViewBody.java, nae-object-library/.../TabbedTaskViewConstants.java
Case and task view bodies add active sort columns and a direction that defaults to desc. They serialize active columns as comma-separated text, or null when unset, and serialize direction as an enumeration-map value. Constants identify both configuration fields.
Sort settings configuration
application-engine/src/main/resources/petriNets/engine-processes/menu/tabbed_case_view_configuration.xml, application-engine/src/main/resources/petriNets/engine-processes/menu/tabbed_task_view_configuration.xml
Both configurations add editable active-column and direction settings. The active-column values remove whitespace. Direction options are asc and desc, with desc as the default. The settings include Slovak and German labels and descriptions.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 8916b

The backend stores the new sorting settings, but their effect on displayed sorting cannot be confirmed from the available code; no specific merge-blocking impact is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: adding column configuration and sorting options to a menu item. It is concise and related to the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files. (2 skipped: 2 unsupported.)



  • Fix all pre-merge checks with AI
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants