Skip to content

Keep parentheses around row constructors in function arguments #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wleeaf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Keep parentheses around row constructors in function arguments #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/syntax/expr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ export const exprMap: CstToDocMap<AllExprNodes> = {
// For now this check here patches up the deficiency in the parser.
!grandParent.distinctKw &&
!isSelectStmt(node.expr) &&
!isCompoundSelectStmt(node.expr)
!isCompoundSelectStmt(node.expr) &&
// (a, b) is a single row argument, not two arguments
!isListExpr(node.expr)
) {
return print("expr");
}
Expand Down
6 changes: 6 additions & 0 deletions test/expr/expr.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,12 @@ describe("expr", () => {
`);
});

it(`preserves parenthesis around row constructor inside function arguments`, async () => {
await testPostgresql(dedent`
SELECT array_position(ids, (1, 1)) FROM tbl
`);
});

describe("case", () => {
it(`formats CASE expression always on multiple lines`, async () => {
await test(dedent`
Expand Down