[abrahamguo]

As discussed in #69, this places joins at the same indentation level as FROM, instead of indenting the whole FROM clause body:

SELECT *
FROM client
LEFT JOIN client_sale ON client_sale.client_id = client.id
RIGHT OUTER JOIN client_attribute
  USING (client_attribute_id, fabulously_long_col_name)

A few related details:

• Comma-separated tables (FROM a, b) keep the existing indented list layout, as do FROM clauses that mix commas with joins. Otherwise, the tables after the first one would start at the beginning of the line.
• PIVOT, UNPIVOT, TABLESAMPLE and FOR SYSTEM_TIME AS OF are now indented under the table they modify, so they don't look like separate clauses.
• A multi-line subquery directly after FROM now starts on the FROM line, the same way a subquery in a join already does.

The first commit adds missing awaits to three tests in from.test.ts, which were passing regardless of their result.

[nene]

Thanks. This looks pretty solid 👍

[nene]

I think it would be better to change this test so that it would use multiple tables in FROM clause. Like FROM one_long_table_name, another_long_table_name.

Then that would align with the description of the test and it would also match the SELECT clause behavior - there we also would run into the same problem when SELECT would only contain a single column.

But we should cover this single-long-table-name case with a separate test inside the from.test.ts file.

[nene]

I'll tweak it by myself.

[nene]

Nice 👍

[nene]

Yeah, this is definitely an awkward case.

I guess that's more of a code which nobody really writes on practice... though I might be mistaken.

In any case it's definitely an edge-case which we don't need to worry too much about as long as the formatting is not completely horrible.