[stefangutica]

Reasoning

• removeDuplicatedESDTTransferEvents dropped every ESDTTransfer event with identical content, including legitimate repeats emitted on the same shard. For example, 9a4e275b6a272431e324da6011fbe87715214f82407b269a25e26032bdd25bcd has 4 SCRs and 4 ESDTTransfer events, two identical pairs on shard 1. The API returned only 2 events and 2 token operations.
• The duplicate it was meant to remove ( fix ESDTTransfer duplicated events #1526) is the same transfer emitted on both the source and the destination shard under the same txHash.

Proposed Changes

• Added shardID to the log events. It is now exposed as logs.events[].shardID.
• An ESDTTransfer event is dropped only when an identical one was already seen on a different shard. Repeats on the same shard are kept.

How to test

• GET /transactions/9a4e275b6a272431e324da6011fbe87715214f82407b269a25e26032bdd25bcd returns 4 ESDTTransfer events in logs and 4 WEGLD transfers in operations.
• GET /transactions/38b1e7163db09950d24fc015b74a129017694f51d20a5053fbc14d2a2dcee97f (cross-shard) still returns the initial ZPAY transfer once, from shard 0.

[github-actions]

k6 load testing comparison.
Base Commit Hash: b40c3c4
Target Commit Hash: 86b9ca9

Metric	Base				Target				Diff
	Avg	Max	90	95	Avg	Max	90	95	Avg	Max	90	95
Pool	21.08	265.74	32.29	35.08	68.25	8215.46	141.16	169.59	+223.68% 🔴	+2991.50% 🔴	+337.21% 🔴	+383.48% 🔴
Nodes	27.31	9267.97	33.83	36.34	786.61	23908.73	155.26	172.37	+2779.85% 🔴	+157.97% 🔴	+358.91% 🔴	+374.28% 🔴
Blocks	25.29	781.53	33.08	35.92	92.06	7477.39	175.88	234.45	+263.99% 🔴	+856.76% 🔴	+431.61% 🔴	+552.75% 🔴
Mex	21.10	221.23	32.27	35.13	67.10	7752.77	149.79	174.65	+218.01% 🔴	+3404.33% 🔴	+364.14% 🔴	+397.10% 🔴
Accounts	21.62	577.54	32.49	35.28	67.61	7790.22	144.01	171.59	+212.70% 🔴	+1248.86% 🔴	+343.19% 🔴	+386.36% 🔴
Tokens	21.07	174.92	32.25	35.01	136.40	8205.74	128.30	139.66	+547.46% 🔴	+4591.27% 🔴	+297.85% 🔴	+298.87% 🔴
Transactions	31.47	11627.89	33.76	36.39	140.72	21851.44	123.02	143.27	+347.18% 🔴	+87.92% 🔴	+264.37% 🔴	+293.68% 🔴
Test Run Duration	60001.86				60002.12

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.