add Multiaddr::ip_addr - #139
Merged
Merged
Conversation
elenaf9
approved these changes
Sep 29, 2026
elenaf9
left a comment
elenaf9
left a comment
Contributor
There was a problem hiding this comment.
One idea, but current implementation also lgtm.
Comment on lines
+232
to
+237
| pub fn ip_addr(&self) -> Option<IpAddr> { | ||
| self.iter().find_map(|p| match p { | ||
| Protocol::Ip4(addr) => Some(IpAddr::V4(addr)), | ||
| Protocol::Ip6(addr) => Some(IpAddr::V6(addr)), | ||
| _ => None, | ||
| }) |
Contributor
There was a problem hiding this comment.
We already implemented From<IpAddr> for Multiaddr. Would it maybe make sense to just analogously implement TryFrom<&Multiaddr> for IpAddr?
Contributor
Author
There was a problem hiding this comment.
huh I like that! But we'd need to add a new Error variant and have Err instead of None for the return type. It would also be less visible the method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.