Skip to content

cache: backfill client-side multi-level raw hits - #2913

Merged
sylvestre merged 2 commits into
mozilla:mainfrom
codeandsolder:upstream-pr/client-side-multilevel-backfill
Oct 22, 2026
Merged

sylvestre merged 2 commits into
mozilla:mainfrom
codeandsolder:upstream-pr/client-side-multilevel-backfill

Conversation

@codeandsolder

Copy link
Copy Markdown
Contributor

Addresses #2796.

Summary

Client-side storage reads cache entries through get_raw(). Multi-level get_raw() returned lower-level hits without running the backfill path used by parsed get() reads, so repeated client-side hits could keep going to the slower remote level.

This change factors the existing raw-byte backfill into one helper and invokes it for both parsed and raw lower-level hits.

Validation

  • full Rust 1.99 library suite: 575 passed, 0 failed
  • focused Rust 1.99 regression proves an L1 get_raw() hit eventually populates L0
  • regression waits on the actual backfill condition with a bounded timeout rather than a fixed sleep
  • cargo fmt and git diff --check
  • Mozilla Rust 1.91 exact CI Clippy gate passes

@codecov-commenter

codecov-commenter commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.96491% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.35%. Comparing base (d72ff0b) to head (6a22a34).

Files with missing lines Patch % Lines
src/cache/multilevel.rs 74.19% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2913      +/-   ##
==========================================
- Coverage   78.13%   75.35%   -2.79%     
==========================================
  Files          74       74              
  Lines       43570    43562       -8     
==========================================
- Hits        34043    32824    -1219     
- Misses       9527    10738    +1211     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/cache/multilevel_test.rs
@codeandsolder-git-wrangler
codeandsolder-git-wrangler Bot force-pushed the upstream-pr/client-side-multilevel-backfill branch from b086130 to 6a22a34 Compare October 20, 2026 01:29
@sylvestre
sylvestre merged commit ebd447e into mozilla:main Oct 22, 2026
51 checks passed
@sylvestre

Copy link
Copy Markdown
Collaborator

Thanks for your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants