Repository navigation
Add errorsupport to the firefox-ios dependency list - #1096
Merged
Merged
Conversation
I've wired up the error ping in app-services (mozilla/application-services#7636). However, I'm not seeing any ping data yet. I think I just need to wire things up in probe-scraper.
BenWu
approved these changes
Oct 22, 2026
Contributor
There was a problem hiding this comment.
Did a dry run of this branch and main to get the output diff (with lastUpdate changes removed):
diff -r output_base/glean/firefox-ios-beta/dependencies output_1096/glean/firefox-ios-beta/dependencies
13a14,17
> "org.mozilla.appservices:errorsupport": {
> "name": "org.mozilla.appservices:errorsupport",
> "type": "dependency"
> },
diff -r output_base/glean/firefox-ios-dev/dependencies output_1096/glean/firefox-ios-dev/dependencies
13a14,17
> "org.mozilla.appservices:errorsupport": {
> "name": "org.mozilla.appservices:errorsupport",
> "type": "dependency"
> },
diff -r output_base/glean/firefox-ios-release/dependencies output_1096/glean/firefox-ios-release/dependencies
13a14,17
> "org.mozilla.appservices:errorsupport": {
> "name": "org.mozilla.appservices:errorsupport",
> "type": "dependency"
> },
diff -r output_base/glean/repositories output_1096/glean/repositories
238a239
> "org.mozilla.appservices:errorsupport",
338a340
> "org.mozilla.appservices:errorsupport",
438a441
> "org.mozilla.appservices:errorsupport",
diff -r output_base/v2/glean/app-listings output_1096/v2/glean/app-listings
1401a1402
> "org.mozilla.appservices:errorsupport",
1501a1503
> "org.mozilla.appservices:errorsupport",
1601a1604
> "org.mozilla.appservices:errorsupport",
This looks correct to me. The actual ping changes happen in the schema generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've wired up the error ping in app-services
(mozilla/application-services#7636). However, I'm not seeing any ping data yet. I think I just need to wire things up in probe-scraper. Tell me if I need to make changes anywhere else.