Repository navigation
Bug 2065466 - Unconditionally set first_run_date to ensure pings are schema-conform - #3608
Merged
Merged
Conversation
badboy
force-pushed
the
failing-test-case-for-bug-2065/xvzkunopkmtx
branch
from
August 21, 2026 13:28
36024c6 to
a27cf00
Compare
badboy
force-pushed
the
failing-test-case-for-bug-2065/xvzkunopkmtx
branch
from
October 29, 2026 09:55
a27cf00 to
d76af03
Compare
travis79
reviewed
Oct 29, 2026
badboy
changed the title
badboy
marked this pull request as ready for review
November 4, 2026 12:29
badboy
force-pushed
the
failing-test-case-for-bug-2065/xvzkunopkmtx
branch
from
November 4, 2026 12:29
a3c5e03 to
0059fa5
Compare
travis79
approved these changes
Nov 4, 2026
…ings can break the schema If Glean is initialized with `upload_enabled=false` the `first_run_date` (and `os`!) is never set, so `follows-collection-enabled=false` pings are invalid against the schema, which requires `first_run_date` (and `os`).
…lication-lifetime core metrics
badboy
force-pushed
the
failing-test-case-for-bug-2065/xvzkunopkmtx
branch
from
November 6, 2026 11:29
0059fa5 to
7410879
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a failing test case for bug 2065466 (test setup copied fromglean-core/rlb/tests/schema.rs)This adds the test that on current
mainwill fail.It then adds the change that unconditionally sets
first_run_dateandosso that these pings pass the current schema (we might still relax the schema).