Bug 2079991 - When one update requests needinfo from several users , the webhook's 'event.changes' has a single 'flag.needinfo' entry for the last requestee only; the others are dropped.

[dklawren]

Sample webhook payloads

The bug object is trimmed to id, is_private and flags. Real payloads carry the full bug.

1. Needinfo requested from several users in one update (the bug being fixed)

Before this change, event.changes had a single flag.needinfo entry, for bob@example.com only. Now each requestee gets its own entry. The routing key still names flag.needinfo once.

{
  "bug": {
    "id": 1629704,
    "is_private": false,
    "flags": [
      {"id": 101, "name": "needinfo", "value": "?", "requestee": {"id": 2, "login": "alice@example.com", "real_name": "Alice"}},
      {"id": 102, "name": "needinfo", "value": "?", "requestee": {"id": 3, "login": "bob@example.com", "real_name": "Bob"}}
    ]
  },
  "event": {
    "action": "modify",
    "routing_key": "bug.modify:flag.needinfo",
    "target": "bug",
    "time": "2026-10-10T20:11:22",
    "user": {"id": 1, "login": "carol@example.com", "real_name": "Carol"},
    "changes": [
      {"field": "flag.needinfo", "removed": "", "added": "? (alice@example.com)"},
      {"field": "flag.needinfo", "removed": "", "added": "? (bob@example.com)"}
    ]
  },
  "webhook_id": 23,
  "webhook_name": "test-bug"
}

2. A single flag changing state is still one change

There is one review removed and one added, so they are paired: ? (alice) → +.

{
  "event": {
    "action": "modify",
    "routing_key": "bug.modify:flag.needinfo,flag.review",
    "target": "bug",
    "changes": [
      {"field": "flag.needinfo", "removed": "", "added": "? (bob@example.com)"},
      {"field": "flag.review", "removed": "? (alice@example.com)", "added": "+"}
    ]
  }
}

3. Several changes to one flag type are not paired

One update deletes Alice's needinfo, grants Bob's, and requests one from Dave. Which removal goes with which addition can't be known (a granted + carries no requestee), so each is reported on its own instead of as made-up pairs like ? (alice) → +.

{
  "event": {
    "action": "modify",
    "routing_key": "bug.modify:flag.needinfo",
    "target": "bug",
    "changes": [
      {"field": "flag.needinfo", "removed": "? (alice@example.com)", "added": ""},
      {"field": "flag.needinfo", "removed": "? (bob@example.com)", "added": ""},
      {"field": "flag.needinfo", "removed": "", "added": "+"},
      {"field": "flag.needinfo", "removed": "", "added": "? (dave@example.com)"}
    ]
  }
}

4. Attachment flags behave the same way

{
  "bug": {
    "id": 1629704,
    "is_private": false,
    "attachment": {"id": 9001, "is_private": false, "file_name": "patch.diff"}
  },
  "event": {
    "action": "modify",
    "routing_key": "attachment.modify:flag.review",
    "target": "attachment",
    "changes": [
      {"field": "flag.review", "removed": "", "added": "? (bob@example.com)"},
      {"field": "flag.review", "removed": "", "added": "? (dave@example.com)"}
    ]
  }
}

[Copilot]

🟡 Changes recommended

Positional pairing can incorrectly associate unrelated same-type flag changes.

1 open finding

• Avoid positional pairing of multiple changed flags · New

What changed in this PR

Updates Push webhook flag handling so multiple same-type flag changes are preserved.

Changes:

• Emits one webhook change per flag update.
• Preserves multiple attachment flag changes and deduplicates routing-key fields.
• Adds regression tests for multi-requestee updates.

File	Description
extensions/​Push/​Extension.pm	Restructures flag changes and routing keys.
extensions/​Push/​t/​flag_changes.t	Tests multiple flag additions and removals.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

The implementation addresses dropped flag changes while preserving existing single-flag behavior with focused regression coverage.

0 open findings

1 resolved since last review

• Avoid positional pairing of multiple changed flags

🧠 Review effort: Balanced

[Xzzz]

Looks good to me. Just two small things inline. Also maybe worth a line in docs/en/rst/extensions/Webhooks/index-user.rst saying that a field can appear more than once in changes.