Repository navigation
Create .env from .env-dist in make preflight - #17461
Merged
Merged
Conversation
Prior to this change, running `make preflight` in a checkout without `.env` silently ran with the settings defaults, not the local development values from `.env-dist`. `preflight` now uses the existing `.env` target, like `pull` does. An existing `.env` is left untouched.
janriokrause
added
Infra
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The single-line change reuses the existing guarded initialization target without altering preflight commands.
No open issues 🎉
What changed in this PR
Ensures make preflight initializes local development configuration before setup runs.
Changes:
- Adds the existing
.envtarget as a prerequisite, creating missing configuration without overwriting local settings.
| File | Description |
|---|---|
| Makefile | Makes preflight depend on .env initialization. |
Review effort: Balanced
stevejalim
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, running
make preflightin a checkout without.envsilently ran with the settings defaults, not the local development values from.env-dist.preflightnow depends on the existing.envtarget, whichpullalready uses. It only copies.env-distwhen.envdoesn't exist, so local settings are never overwritten. This also keepsmake preflightconsistent with Springfield.Port of mozmeao/springfield#1971.