Skip to content

Bug 2085007 - Address cargo audit errors in application-services [ci full] - #7683

Merged
freshstrangemusic merged 1 commit into
mainfrom
freshstrangemusic/push-ulspltpzsmuu
Oct 22, 2026
Merged

freshstrangemusic merged 1 commit into
mainfrom
freshstrangemusic/push-ulspltpzsmuu

Conversation

@freshstrangemusic

Copy link
Copy Markdown
Member

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@freshstrangemusic
freshstrangemusic requested a review from a team as a code owner October 22, 2026 14:18
@freshstrangemusic

Copy link
Copy Markdown
Member Author

This does update zip to a version not in m-c but it is only used by an excluded crate: https://searchfox.org/firefox-main/source/Cargo.toml#134

@freshstrangemusic freshstrangemusic changed the title Bug 2085007 - Address cargo audit errors in application-services Bug 2085007 - Address cargo audit errors in application-services [ci full] Oct 22, 2026

@bendk bendk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moz-central is on 2.4.2, so I think this will require an audit on the next vendor. I'm not totally sure since this is "just" a CLI crate, but I think it will. I think there's a google audit for 6.0.0, so we might just need to audit 6 -> 9. Are you up for doing that?

@bendk bendk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just read your comment and realized you had already checked into this. :shipit:

@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-ulspltpzsmuu branch from f17e9c5 to ae6912e Compare October 22, 2026 15:30
@freshstrangemusic
freshstrangemusic added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 9d73b60 Oct 22, 2026
62 checks passed
@freshstrangemusic
freshstrangemusic deleted the freshstrangemusic/push-ulspltpzsmuu branch October 22, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants