Repository navigation
Bug 2047640 - Cut ads-client telemetry strings to Glean's 255-byte limit - #7680
Merged
Merged
Conversation
Almaju
enabled auto-merge
October 22, 2026 16:22
thesuzerain
reviewed
Oct 22, 2026
|
|
||
| /// Glean drops the end of longer string values and records an | ||
| /// `invalid_overflow` error (bug 2047640). | ||
| const MAX_STRING_SIZE: ByteSize = ByteSize::b(255); |
Collaborator
There was a problem hiding this comment.
nit: Do we want the constant to be midway through the file?
thesuzerain
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug 2047640:
invalid_overflowerrors onads_client.client_error.The labeled_string metrics receive the whole nested error message, which can exceed Glean's 255-byte string limit. Every string value is now cut to 255 bytes on a char boundary before it reaches the
MozAdsTelemetrycallback.Pull Request checklist