Skip to content

Bug 2084735 - Update to reqwest 0.13.5 in viaduct-backend-rust [ci full] - #7677

Merged
freshstrangemusic merged 1 commit into
mainfrom
freshstrangemusic/push-poqxtmpkzlmn
Oct 22, 2026
Merged

freshstrangemusic merged 1 commit into
mainfrom
freshstrangemusic/push-poqxtmpkzlmn

Conversation

@freshstrangemusic

Copy link
Copy Markdown
Member

Due to multiple verisons of reqwest (0.12 and 0.13), we were packaging a version of schannel on windows that has UB. This updates our dependency on reqwest to 0.13.5 everywhere, which gives us a more modern version of schannel.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@bendk bendk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for doing this.

@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-poqxtmpkzlmn branch from 1b6993e to 8ad8458 Compare October 22, 2026 16:13
@freshstrangemusic
freshstrangemusic requested a review from a team as a code owner October 22, 2026 16:13
@freshstrangemusic
freshstrangemusic removed the request for review from a team October 22, 2026 17:34
Due to multiple verisons of reqwest (0.12 and 0.13), we were packaging a
version of `schannel` on windows that has UB. This updates our
dependency on reqwest to 0.13.5 everywhere, which gives us a more modern
version of `schannel`.
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-poqxtmpkzlmn branch from 8ad8458 to 5426cf9 Compare October 22, 2026 17:40
@freshstrangemusic
freshstrangemusic added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit e1f3ac9 Oct 22, 2026
61 of 62 checks passed
@freshstrangemusic
freshstrangemusic deleted the freshstrangemusic/push-poqxtmpkzlmn branch October 22, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants