Skip to content

Fix visibility attribute on Windows for export_properties function #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhaschke merged 1 commit into from
Sep 10, 2026
Merged

Fix visibility attribute on Windows for export_properties function #761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/python/bindings/src/properties.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ bool PropertyConverterBase::insert(const std::type_index& type_index, const std:
return REGISTRY_SINGLETON.insert(type_index, ros_msg_name, to, from);
}

__attribute__((visibility("default"))) // export this symbol as visible in the shared library
void export_properties(py::module& m) {
// export this symbol as visible in the shared library
PYBIND11_EXPORT void export_properties(py::module& m) {
// clang-format off
py::classh<Property>(m, "Property", "Holds an arbitrarily typed value and a default value")
.def(py::init<>())
Expand Down
Loading