Skip to content

MOSIP-45750: Upgrade apitest-masterdata to Java 25 - #1396

Open
mohanachandran-s wants to merge 1 commit into
mosip:developfrom
mohanachandran-s:java25-upgrade
Open

mohanachandran-s wants to merge 1 commit into
mosip:developfrom
mohanachandran-s:java25-upgrade

Conversation

@mohanachandran-s

@mohanachandran-s mohanachandran-s commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Jira: MOSIP-45750
Depends on: mosip/mosip-functional-tests#2015 (apitest-commons 1.8.0-java25-SNAPSHOT). Merge that one first.

What

Moves apitest-masterdata (api-test/) from Java 21 to Java 25. The admin service itself is unchanged and stays on Java 21.

  • Consumes apitest-commons 1.8.0-java25-SNAPSHOT (previously 1.6.0).
  • maven.compiler.release is 25, with maven-compiler-plugin 3.16.0 using <release> and Lombok 1.18.48 in annotationProcessorPaths.
  • Plugins: jar 3.5.1, shade 3.6.2 (createDependencyReducedPom=false), javadoc 3.12.0.

Verification

  • mvn clean install passes on JDK 25.0.5, and the classes are class file 69. The jar-with-dependencies starts on JDK 25.
  • The smoke suite ran on api-internal.released, comparing the base (develop, JDK 21, commons 1.6.0) with this branch (JDK 25):
    • Each language ran 248 cases with identical totals.
    • No case went from PASS to FAIL in any of the 6 languages (eng, ara, fra, hin, kan, tam).
  • The single failure, TC_Masterdata_FetchAllUserDetails_01, fails on develop as well, so this change did not cause it.
  • The JVM printed no UnsupportedClassVersion, NoClassDefFound, sun.misc.Unsafe or restricted-method warnings.

Known gaps (not in this PR)

  • The api-test CI jobs use mosip/kattu@master-java21 (Java 21 hardcoded), so the CI build will fail until a Java 25 kattu ref exists.
  • api-test/Dockerfile stays on mosipid/openjdk-21-jre:21.0.4, which can't run class file 69. There is no mosipid JRE 25 image yet.

🤖 Generated with Claude Code

- Consume apitest-commons 1.8.0-java25-SNAPSHOT (was 1.6.0)
- maven.compiler.release 25; maven-compiler-plugin 3.16.0 with <release>
  and Lombok 1.18.48 in annotationProcessorPaths
- jar 3.5.1, shade 3.6.2 (createDependencyReducedPom=false), javadoc 3.12.0

Masterdata smoke on api-internal.released: no PASS->FAIL against upstream/develop
in any of the 6 languages. CI (kattu master-java21) and the Dockerfile
(openjdk-21-jre) stay on Java 21 until a Java 25 ref and base image exist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>
@coderabbitai

coderabbitai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI; Enforced overrides: Organization
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: dc2e67ca-9b74-4d7b-a6a2-8f3f9506193f
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ckm007

ckm007 commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

🔗 Linked PR

@ckm007

ckm007 commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

🔗 Linked PR

@ckm007

ckm007 commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

🔗 Linked PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants