Skip to content

fix: ignored tests name the real render-sw recipe, and docs match the code - #165

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/doc-drift
Nov 15, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/doc-drift

Conversation

@kixelated

@kixelated kixelated commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Completes quest/m0/doc-drift.md and deletes it.

Problem

59 #[ignore] reasons (54 in rs/moq-scene/src/compositor.rs, 5 in rs/moq-studio/src/engine.rs) said just rs render-sw, a recipe that doesn't exist. record.rs said a program recording shares the live encoders, but it has its own. CONTRIBUTING.md asked every PR for a conventional title and Problem/Approach/Impact sections, which quest-only PRs never follow.

Approach

  • Every reason now says just render-sw.
  • New sh/check-ignore-recipes.sh, run first in just check: for every #[ignore = "..."] in tracked .rs files (so not the moq submodule), it fails if a just <recipe> named there is missing from just --summary.
  • rs/moq-studio/src/record.rs module doc: the program half now says the recording reads a hidden broadcast that holds its own full-size encodes of the video (full quality whatever the grant) and of the mix (engine.rs recorded_video, record: true). The sources' half was already accurate and stays as it was.
  • CONTRIBUTING.md: a PR that only adds or edits quests uses a quest type title, with or without a scope, and follows the quest guide's format instead of the section template. This follows the maintainer's 2026-11-12 decision in the quest's Plan.

Impact

  • just check fails on an #[ignore] reason that names a missing recipe. No user-facing change. No public API or wire change.

Landing

Open draft moq-dev/studio#146 adds two more just rs render-sw reasons. Its Check, which runs once it's marked ready, tests its merge with main, so the new lint will flag both. If #146 is ready with a passing Check when this lands, update its branch (gh pr update-branch 146) and hold it from merging until Check passes again. If #146 lands first, merge main here and the lint will flag its reasons to fix in this PR.

Validation

  • quest gate just ci: passes (305 tests, quest check ok).
  • Negative tests of the lint: changing one engine reason back to just rs render-sw fails it (names 'just rs'); changing shots.rs's reason to `just shot` fails it; restoring both passes.
  • A second check that the reasons are true: cargo nextest list --run-ignored only with render-sw's own filters selects 55 moq-scene tests (54 compositor + 1 layers, matching the reasons) and 7 moq-studio tests (6 engine + setup; the 7th engine test is in the recipe's PipeWire line). tests/browser.rs's 13 run through binary(browser). I didn't run the GPU tests themselves: the recipe is unchanged.

Caused by

  • No single PR: the reasons came from moq-dev/moq, where rs was a just module. The stand-up commit 30457ba moved the recipe to the root justfile and left the reasons stale.

Follow-ups

None.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm A)

(Written by Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: dbee41b

  • Base: origin/main at 5a74c18

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1dbe5-9c4a-7d83-adba-44b180f6f96e, round 1

  • Score: 9/10, No actionable defects were found; the narrowly scoped recipe corrections and recording documentation match the source, but execution checks remain unverified.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1dbe5-9c7d-7260-9736-fd0a0207fa5a, round 1

  • Score: 9/10, No actionable defects were found in the narrowly scoped documentation corrections and recipe-reference lint; commands and checks were not run, as instructed.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 14, 2026 12:57
Quest-Claim: d60315a3c4396544
… code

Fix 59 #[ignore] reasons that said `just rs render-sw` and add a `just
check` step that fails when a reason names a recipe the root justfile
lacks. record.rs now says the program's recording has its own encoder,
and CONTRIBUTING.md exempts quest-only PRs from the template.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Docs and test notes match the code fix: ignored tests name the real render-sw recipe, and docs match the code Nov 14, 2026
@kixelated
kixelated marked this pull request as ready for review November 14, 2026 21:11
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 39743ddb-f4a6-42be-99c3-77894494c623
Commits

Reviewing files that changed from the base of the PR and between 779cb40 and d3a3777.

Files selected for processing: 7

  • CONTRIBUTING.md
  • justfile
  • quest/m0/doc-drift.md
  • rs/moq-scene/src/compositor.rs
  • rs/moq-studio/src/engine.rs
  • rs/moq-studio/src/record.rs
  • sh/check-ignore-recipes.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — the full diff of 7 files. The compositor.rs and engine.rs edits are 59 one-for-one text swaps.

  • #[ignore] reasons: all 59 now say just render-sw.
  • sh/check-ignore-recipes.sh: it runs first in just check. It scans tracked .rs files only, so the moq submodule is skipped. It fails on any just <recipe> named in an #[ignore] reason that just --summary doesn't list. I found nothing wrong with its quoting, pipefail or process-substitution behaviour.
  • record.rs module doc: the program half now describes the hidden broadcast with its own full-size encodes. The sources half is unchanged.
  • CONTRIBUTING.md: quest-only PRs use a quest type title and the quest guide's format.
  • quest/m0/doc-drift.md: deleted, as the PR says it should be.

I didn't run just ci or the lint myself. The PR body reports it passing, plus negative tests of the lint.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated merged commit b880e8f into main Nov 15, 2026
3 checks passed
@kixelated
kixelated deleted the quest/m0/doc-drift branch November 15, 2026 01:29
@kixelated kixelated mentioned this pull request Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant