Repository navigation
fix: ignored tests name the real render-sw recipe, and docs match the code - #165
Merged
Merged
Conversation
Quest-Claim: d60315a3c4396544
… code Fix 59 #[ignore] reasons that said `just rs render-sw` and add a `just check` step that fails when a reason names a recipe the root justfile lacks. record.rs now says the program's recording has its own encoder, and CONTRIBUTING.md exempts quest-only PRs from the template. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 14, 2026 21:11
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — the full diff of 7 files. The compositor.rs and engine.rs edits are 59 one-for-one text swaps.
#[ignore]reasons: all 59 now sayjust render-sw.sh/check-ignore-recipes.sh: it runs first injust check. It scans tracked.rsfiles only, so themoqsubmodule is skipped. It fails on anyjust <recipe>named in an#[ignore]reason thatjust --summarydoesn't list. I found nothing wrong with its quoting,pipefailor process-substitution behaviour.record.rsmodule doc: the program half now describes the hidden broadcast with its own full-size encodes. The sources half is unchanged.CONTRIBUTING.md: quest-only PRs use aquesttype title and the quest guide's format.quest/m0/doc-drift.md: deleted, as the PR says it should be.
I didn't run just ci or the lint myself. The PR body reports it passing, plus negative tests of the lint.
claude-sonnet-5-5 | 𝕏
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Completes quest/m0/doc-drift.md and deletes it.
Problem
59
#[ignore]reasons (54 inrs/moq-scene/src/compositor.rs, 5 inrs/moq-studio/src/engine.rs) saidjust rs render-sw, a recipe that doesn't exist.record.rssaid a program recording shares the live encoders, but it has its own.CONTRIBUTING.mdasked every PR for a conventional title and Problem/Approach/Impact sections, which quest-only PRs never follow.Approach
just render-sw.sh/check-ignore-recipes.sh, run first injust check: for every#[ignore = "..."]in tracked.rsfiles (so not themoqsubmodule), it fails if ajust <recipe>named there is missing fromjust --summary.rs/moq-studio/src/record.rsmodule doc: the program half now says the recording reads a hidden broadcast that holds its own full-size encodes of the video (full quality whatever the grant) and of the mix (engine.rsrecorded_video,record: true). The sources' half was already accurate and stays as it was.CONTRIBUTING.md: a PR that only adds or edits quests uses aquesttype title, with or without a scope, and follows the quest guide's format instead of the section template. This follows the maintainer's 2026-11-12 decision in the quest's Plan.Impact
just checkfails on an#[ignore]reason that names a missing recipe. No user-facing change. No public API or wire change.Landing
Open draft moq-dev/studio#146 adds two more
just rs render-swreasons. Its Check, which runs once it's marked ready, tests its merge withmain, so the new lint will flag both. If #146 is ready with a passing Check when this lands, update its branch (gh pr update-branch 146) and hold it from merging until Check passes again. If #146 lands first, mergemainhere and the lint will flag its reasons to fix in this PR.Validation
quest gate just ci: passes (305 tests,quest checkok).just rs render-swfails it (names 'just rs'); changingshots.rs's reason to`just shot`fails it; restoring both passes.cargo nextest list --run-ignored onlywithrender-sw's own filters selects 55 moq-scene tests (54 compositor + 1 layers, matching the reasons) and 7 moq-studio tests (6 engine +setup; the 7th engine test is in the recipe's PipeWire line).tests/browser.rs's 13 run throughbinary(browser). I didn't run the GPU tests themselves: the recipe is unchanged.Caused by
rswas ajustmodule. The stand-up commit 30457ba moved the recipe to the rootjustfileand left the reasons stale.Follow-ups
None.
Models
Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm A)
(Written by Opus 5.5)
Review
Rewritten by
quest reviewafter each round.Head: dbee41b
Base: origin/main at 5a74c18
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1dbe5-9c4a-7d83-adba-44b180f6f96e, round 1Score: 9/10,
No actionable defects were found; the narrowly scoped recipe corrections and recording documentation match the source, but execution checks remain unverified.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1dbe5-9c7d-7260-9736-fd0a0207fa5a, round 1Score: 9/10,
No actionable defects were found in the narrowly scoped documentation corrections and recipe-reference lint; commands and checks were not run, as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none