Skip to content

quest(m0): a broadcast source's sound glides onto a moved delay - #149

Merged
kixelated merged 2 commits into
mainfrom
quest-plan/bus-stretch
Nov 13, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest-plan/bus-stretch

Conversation

@kixelated

@kixelated kixelated commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Plans the follow-up moq-dev/studio#144 left: a jitter-target step writes silence into a broadcast source's sound or skips it, because moq-audio's bus places positioned audio exactly while moq play's sink stretches.

Summary

  • Adds quest/m0/pin-bus-stretch.md [S]: pin moq-audio's stretching Positioned channel and write playout through it with a stretch bound, so the sound glides onto a moved delay. It waits on moq-dev/moq#8605's quest landing upstream and requires pin-main.

Decisions

From the maintainer's /quest-plan interview on 2026-11-12:

  • Goal: ✅ moq-audio's bus stretches scheduled audio, reusing its playback sink's NetEq stretch, and the studio pins it (rejected: adjusting it).
  • API: ✅ Positioned gains a stretch bound, zero meaning exact (rejected: a new channel kind).
  • Milestones: ✅ moq m1, studio m0 (rejected: moq m3 with studio m0; moq m3 with studio m2).

Public API and wire impact: none (quest files only).

Follow-ups

None.

Validation

Quest files only, no behavior to exercise. quest check passes.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 28ca83d

  • Base: origin/main at 6bd0c9f

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1d260-316c-7f31-892e-da3b840b34c1, round 2

  • Score: 10/10, The added plan correctly identifies the current Writer’s overlap trimming and gap behavior and scopes the required adaptation to the upstream stretching channel.

  • Findings: none

  • Reviewer: opencode, opencode-go/deepseek-v4.1-flash, high effort

  • Session: ses_e2d9fc6daffev50gICqFN7P0Ao, round 2

  • Score: 9/10, The Plan now records the required Writer change and matches the upstream quest's nonzero-bound semantics, so the earlier step-down gap is fixed; only the studio-side regression test remains implicit, which keeps it short of a 10.

  • Findings: none

  • The last round's findings, at 65962fb:

    • Fixed: medium, quest/m0/pin-bus-stretch.md:7: Step-down target moves still skip audio because the writer trims the moved-earlier write; The new Plan at quest/m0/pin-bus-stretch.md:22-26 says the Writer stops cutting overlaps and leaving gaps, writes each frame after the last, and hands the channel its due position, which the updated upstream quest matches by making a nonzero-bound write due at its position.

kixelated and others added 2 commits November 12, 2026 16:46
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…us stretches

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 13, 2026 01:00
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a01aafa1-6e85-49ab-a014-fed405cf654a
Commits

Reviewing files that changed from the base of the PR and between 6bd0c9f and 28ca83d.

Files selected for processing: 1

  • quest/m0/pin-bus-stretch.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge (squash) November 13, 2026 01:01

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the single quest file added in this PR.

  • quest/m0/pin-bus-stretch.md: Plans pinning moq-audio's stretching Positioned channel and changing playout's Writer to write each frame after the last with a 2 s stretch bound. It waits on the upstream quest and requires pin-main.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated merged commit 74e5378 into main Nov 13, 2026
4 checks passed
@kixelated
kixelated deleted the quest-plan/bus-stretch branch November 13, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant