Repository navigation
quest-unblock: settle sound stalls and the composition, clear cleared waits - #143
Merged
Merged
Conversation
… waits - pin-sync: adopt moq's decoupled rule for a sound stall. - compose: guests and local sources are listed by a composition, its own broadcast of catalogs; every published source is its own broadcast. - packaging/macos: moq-dev/moq#8251 landed and is pinned. - pin-aac-encode, pin-audio-filters, audio-filters: moq-dev/moq#8421 merged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… as the composition Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 12, 2026 09:22
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the maintainer's answers from
/quest-unblockon 2026-11-12, and clears waits whose conditions resolved.Decisions
Speakerplayhead of its own).include; republishing guests)./quest-plan).The layout quest grows from M to L: it now covers moving local sources to their own broadcasts and replacing
live.kixel.studio.layers, not only guests. The epic README,server.md, andhang-layers.mdfollow.Cleared
79960a9ddis 124 commits behind it). The outside wait becomes a Required link to pin-main, which brings it, and the camera picture becomes a check by hand on a Mac.audio-filters.md: dropped "moves to moq's m3 in moq-dev/moq#8421", which has merged. The upstream work itself has not landed, so the waits stay.Still waiting (unchanged)
Follow-ups
quest/m3/layers/spec.md,play.md, andwatch.mdfor the composition rather than a layer layout track (for/quest-planin moq's tree). spec.md's Waiting also names the studio's watch prototype quest, which merged as moq-dev/studio#140.Validation
Quest files only, no behavior to exercise.
quest checkandjust ci(308 tests passed) pass. The macOS pin claim was checked withgh api repos/moq-dev/moq/compare/2be959ba...79960a9dd(statusbehind, 124).Models
Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.Head: a3b028a
Base: origin/main at ea0826b
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1cf03-92b5-75a1-8b70-3afad711ba29, round 2Score: 9/10,
The incremental changes clarify quest dependencies and validation requirements without introducing actionable defects; quest-specific validation remains unavailable under the review constraints.Findings: none
Reviewer: opencode, opencode-go/deepseek-v4.1-flash, high effort
Session:
ses_e30fc68dfffem2bWvq3OAKIhOI, round 2Score: 10/10,
All four earlier findings are fixed at the head and the three changed files introduce no new defect: the macOS quest now records #8251 as landed after the pin and requires pin-main, the camera check is manual, hang's wait is composition-shaped, and the server sentence reads correctly.Findings: none
The last round's findings, at 82321fd:
quest/m0/packaging/macos.md:48:The macOS camera fix is not in the pin, so the wait is cleared early;quest/m0/packaging/macos.md:47-52 now says #8251 (`2be959ba9`) landed on moq's main after the studio's pin, and lines 54-56 require pin-main, which pins a main containing `2be959ba9`.quest/m0/packaging/macos.md:49:The launch check cannot confirm a camera picture;quest/m0/packaging/macos.md:50-52 now makes the camera picture a check by hand on a Mac, noting the launch check only lists devices and hosted runners have no camera.quest/m2/compose/hang-layers.md:36:hang's Waiting check still specifies the layer layout this PR replaces;quest/m2/compose/hang-layers.md:28-38 now names hang's composition in the Waiting and its check, describes the three layer quests as the current plan to be replanned, and discounts a replanned file without the work landing.quest/m2/compose/server.md:30:The rewritten server sentence is a fragment;quest/m2/compose/server.md:30-31 now reads "until that lands, it flattens the provisional ... track", restoring the missing verb.