Repository navigation
docs(quest): record the 2026-11-11 unblock decisions - #702
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
moq-pin: Goal no longer points at the removed wait; this quest owns the exporter change; the two moq waits and the stale ffi.toml entries carry dated evidence at moq d528b675. generics: four items leave without (a). small-shapes resizes to S for option (b). fork: the wait waits on new evidence instead of re-asking the settled question. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 11, 2026 04:07
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Records the decisions from the 2026-11-11
/quest-unblocksession in the quests, and removes the maintainer waits they settle. Also records the 2026-11-11 research at moqmaind528b675on moq-pin's waits and generics' items.Public API and wire impact: none; only the quest tree changes.
Decisions
[T; N]as a fixed-size C struct<prefix>_array_<T>_<N>(rejected: (a) bytes with a length check; (c) refused).Filtercollects.Instantis an opaque object.tracing::Levelis a plain enum.PR decisions, applied by
/quest-iterate:RUSTC.Research recorded (2026-11-11, moq
d528b675)rind0.3.1 and 0.3.2 have an unconditionalasm!(src/low/generic/md5.rs:22), so wasm32 fails with E0658, fixed inrindthen bumped in moq; moq-tokio still tripsrecursion_depth_exceeding_limitatrs/moq-tokio/src/client.rs:722. The bump also has to fix 37 staleffi/moq/ffi.tomlentries and new refusals.server::Request::withinleaves through a planned moq quest (Request::poll_expired/expired(); no moq-dev/moq PR yet);kio::waitstops being reachable once the pin bump dropspub use kio;;panic::isolateleaves when the stand-in stops re-exportingmoq_tokio::panic, a rust2-side change this quest makes. The other five kio items still need (a).Review fixes
kio::PendingandVersionwere covered by Waiting, which this PR removed; it now points at the exporter change, which the quest states it owns.panicre-export also dropspanic::message, so four of the eleven items leave without (a)./quest-unblockwith nothing new; it now waits on a report adding evidence after the decision.Models
Size: S
Implementer: Claude Code, claude-opus-5-5, high effort
Implementer: Claude Code, claude-opus-5-5 (review fixes and research)
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.01a1c8c9-07df-7d31-a888-373cd2b68c6d, round 2The updated plan explicitly records the accepted eager-collection trade-off and its reliance on moq’s pure predicates, resolving the sole review concern.quest/m1/ffi-refusals/std-types.md:25:Preserve predicate effects when exporting filtered iterators;The base’s std-types.md:27-33 explicitly presented the early-stop trade-off for maintainer decision, and the head’s std-types.md:23-29 records acceptance with the previously omitted rationale concerning moq’s pure predicates.