Skip to content

docs(quest): record the 2026-11-11 unblock decisions - #702

Merged
kixelated merged 3 commits into
mainfrom
quest-unblock/2026-11-11
Nov 11, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest-unblock/2026-11-11

Conversation

@kixelated

@kixelated kixelated commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Records the decisions from the 2026-11-11 /quest-unblock session in the quests, and removes the maintainer waits they settle. Also records the 2026-11-11 research at moq main d528b675 on moq-pin's waits and generics' items.

Public API and wire impact: none; only the quest tree changes.

Decisions

  • generics.md: ✅ (a) foreign futures and kept closures cross from C (rejected: (b) moq's signatures change). The maintainer dislikes callbacks and closures in an API, so a moq quest for a closure-free API gets planned only if research finds a simpler one; it doesn't gate this quest.
  • moq-pin.md: ✅ (a) export a type the crate root doesn't reach by its defining path (rejected: (b) moq makes it reachable). moq's two build conditions still wait.
  • small-shapes.md: ✅ (b) [T; N] as a fixed-size C struct <prefix>_array_<T>_<N> (rejected: (a) bytes with a length check; (c) refused).
  • std-types.md:
    • ✅ Filter collects.
    • ✅ serde_json's map iterators collect.
    • ✅ Instant is an opaque object.
    • ✅ tracing::Level is a plain enum.
  • m4/fork.md: ✅ not yet enough to pay for a fork; the ledger stays open (rejected: fork now; delete the ledger).

PR decisions, applied by /quest-iterate:

Research recorded (2026-11-11, moq d528b675)

  • moq-pin.md: both moq-dev/moq waits still hold, recorded as dated evidence with their conditions unchanged: rind 0.3.1 and 0.3.2 have an unconditional asm! (src/low/generic/md5.rs:22), so wasm32 fails with E0658, fixed in rind then bumped in moq; moq-tokio still trips recursion_depth_exceeding_limit at rs/moq-tokio/src/client.rs:722. The bump also has to fix 37 stale ffi/moq/ffi.toml entries and new refusals.
  • generics.md: server::Request::within leaves through a planned moq quest (Request::poll_expired/expired(); no moq-dev/moq PR yet); kio::wait stops being reachable once the pin bump drops pub use kio;; panic::isolate leaves when the stand-in stops re-exporting moq_tokio::panic, a rust2-side change this quest makes. The other five kio items still need (a).

Review fixes

  • moq-pin.md's Goal said kio::Pending and Version were covered by Waiting, which this PR removed; it now points at the exporter change, which the quest states it owns.
  • generics.md: dropping the stand-in's panic re-export also drops panic::message, so four of the eleven items leave without (a).
  • small-shapes.md resized from XS to S: option (b) adds a new C type and a fixed-size form in every language, more than (a)'s reuse of bytes.
  • fork.md's wait re-asked the question just answered, so it would resurface every /quest-unblock with nothing new; it now waits on a report adding evidence after the decision.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, high effort
Implementer: Claude Code, claude-opus-5-5 (review fixes and research)

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, medium effort
  • Session: 01a1c8c9-07df-7d31-a888-373cd2b68c6d, round 2
  • Head: cb2b278
  • Base: origin/main at fa34d00
  • Score: 10/10, The updated plan explicitly records the accepted eager-collection trade-off and its reliance on moq’s pure predicates, resolving the sole review concern.
  • Findings: none
  • The last round's findings, at 0a0c7bc:
    • Refuted: medium, quest/m1/ffi-refusals/std-types.md:25: Preserve predicate effects when exporting filtered iterators; The base’s std-types.md:27-33 explicitly presented the early-stop trade-off for maintainer decision, and the head’s std-types.md:23-29 records acceptance with the previously omitted rationale concerning moq’s pure predicates.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog

pullfrog Bot commented Nov 11, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

kixelated and others added 2 commits November 10, 2026 20:05
moq-pin: Goal no longer points at the removed wait; this quest owns the
exporter change; the two moq waits and the stale ffi.toml entries carry
dated evidence at moq d528b675. generics: four items leave without (a).
small-shapes resizes to S for option (b). fork: the wait waits on new
evidence instead of re-asking the settled question.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 11, 2026 04:07
@coderabbitai

coderabbitai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bc14e961-87d3-464d-9338-ca94e67ddf20
Commits

Reviewing files that changed from the base of the PR and between fa34d00 and cb2b278.

Files selected for processing: 5

  • quest/m1/ffi-refusals/generics.md
  • quest/m1/ffi-refusals/moq-pin.md
  • quest/m1/ffi-refusals/small-shapes.md
  • quest/m1/ffi-refusals/std-types.md
  • quest/m4/fork.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit fd73635 Nov 11, 2026
7 checks passed
@kixelated
kixelated deleted the quest-unblock/2026-11-11 branch November 11, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant