Repository navigation
chore(quest): finish the narrowed stand-in quest - #698
Merged
Merged
Conversation
Quest-Claim: 097e673fef37fe1f
The stand-in narrowing landed in #683. Delete its quest and the links to it, and keep its decisions in the PR body. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 10, 2026 20:22
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
marked this pull request as draft
November 10, 2026 20:23
…efusals/narrow-standin # Conflicts: # quest/m1/ffi-export/refusals/README.md
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The stand-in's narrowing, which this quest claimed, landed on
mainas moq-dev/rust2#683. The quest file and the links to it were still onmain, so the quest read as open work it no longer is.Approach
Verified each Goal item on
main: the stand-in exports the session side (Client,Server,Connection,Transport,Log,tls,panic, the errors, and the listed config, server, listener, and helper types);pub use ::moq_tokio::*is gone;ffi/moq/ffi.tomlhas 128 excludes, all naming items inside the stand-in. Then:quest/m1/ffi-export/refusals/narrow-standin.md.Requiredentry from the epic README, and reworded the epic's sentence on the landing order to name feat(ffi)!: export only moq-tokio's session side in the stand-in #683 instead.generics.mdandstd-types.mdat feat(ffi)!: export only moq-tokio's session side in the stand-in #683 where they linked the quest.No code changed. The decisions the quest recorded are below.
Impact
No public API change. The export's C names and the stand-in's exports are as #683 left them.
Census
just ffi censusat this head, and at30faf4fb(main before #683) with the same moq source, sincemoq_revis unchanged between the two. Refused items per crate, counted by the crate each item is defined in:Refused types stay at 6 in both. By construct: functions 18 to 11, methods and fields 146 to 109, constants 1 to 0, other items 11 to 4.
The epic README's earlier figures (1111 items, 84 in moq-tokio, 321 types) come from a tree before #668 and #671, which changed the exporter. They cannot be reproduced on the current exporter, so this table uses
30faf4fbas the before.Decisions
From the quest, decided with the maintainer:
Requiredlink held.Client::newandServer::newexport again. Rejected: rewriting the seven fixtures to the narrow list.Configs. Rust keepsconnect::Config,listen::Config, andquic::Config, and C keepsmoq_tokio_connect_Config_*. Go, which clashes, keeps its module segment, so the names aretokio.ConnectConfig,tokio.ListenConfig, andtokio.QuicConfig. Rejected: renaming in the stand-in, and re-exporting whole modules.rustls,notify,congestion,cli::usage_rs,quic::web'shttpandprotore-exports, andquic::driver'sSiderefusals. Every item the stand-in names exists at moqffcb7cd9.Choices made in this PR, without asking:
30faf4fb, as above, not the 1111 figure the epic recorded.Follow-ups
None to plan. The epic's children still carry their construct counts at the pin, and each re-measures when it lands, as the epic says.
Models
Size: XS
Implementer: Claude, claude-haiku-5-5, high effort
(Written by Haiku 5.5 with high effort)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.01a1c64d-78d8-7950-a286-a094943b4cf0, round 3The branch’s own changes retire the completed quest and replace its remaining references with the implementing PR; no actionable defects were found.