You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci(bench): run the build benchmark only when its result can change - #686
Finishes quest/m0/bench-trim.md: the build-speed benchmark costs CI only when its result can change.
Changes
bench.yml: drops the nightly schedule (about 3.5 runner-hours a night on fully pinned inputs) and the Bench (moq nix) and pure jobs. It still runs on manual dispatch and on a PR that changes the harness, its workflow, the build-bench shell, or bench-ra-jit.
Deletes bench/build/nix.{sh,nix,toml}, nix-report.jq, just bench-nix, the flake's bench-nix package and its now-unused mbx input, and the nixfmt references to nix.nix.
Drops the regex and wasmparser corpora, regex.Cargo.lock, and the code only they used: the pure rule (check_graph becomes check_no_c) and the corpus lock field.
README: the "Nix builds for moq" decision and table stay, with a short note on what each variant measured, pinned to the moq rev it used (011402e). The pure corpora produced no README table.
Choices made without asking
I removed the flake's mbx input since nothing else used it. #426 uses the host's mbx, not this input.
I dropped the corpus lock field instead of keeping it unused.
Public API: none. Wire: none.
Checks
quest gate just ci passed locally.
Models
Size: S
Implementer: Claude Code, Opus 5.5, low effort
Drop the nightly schedule, the moq Nix comparison, and the pure corpora
(regex, wasmparser); keep the Nix table in the README.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
changed the title
Trim the build-speed benchmark
ci(bench): run the build benchmark only when its result can change
Nov 10, 2026
No actionable comments were generated in the recent review.
Walkthrough
The benchmark workflow no longer runs on a daily schedule and no longer includes a separate Nix benchmark job. Its pull-request path comparison includes changes under bench/build and the workflow file, excluding Markdown. The pure corpus entries and checks were removed, and no-c checks remain for marked corpora. Checkouts now use the pinned revision’s existing lockfile. The Nix benchmark tooling and its command were removed; the README now records historical Nix measurements.
Merge Risk: Minimal · up to a40fc
The benchmark changes have no identified merge-blocking risk.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly summarizes the main change: run the build benchmark only when relevant changes can affect its result.
Description check
The description explains the benchmark trigger changes and the related removal of Nix benchmark components and corpora.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files. (4 skipped: 4 unsupported.)
Finishing Touches
Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: fc506dd9-167a-4c36-9854-6f0a127c2eb5
Commits
Reviewing files that changed from the base of the PR and between ddf231a and a40fc58.
Files ignored due to path filters: 2
bench/build/regex.Cargo.lock is excluded by !**/*.lock
flake.lock is excluded by !**/*.lock
Files selected for processing: 13
.github/workflows/bench.yml
bench/build/README.md
bench/build/corpus.toml
bench/build/nix-report.jq
bench/build/nix.nix
bench/build/nix.sh
bench/build/nix.toml
bench/build/run.sh
flake.nix
justfile
quest/m0/README.md
quest/m0/bench-trim.md
sh/dispatch.sh
Files with no reviewable changes: 7
quest/m0/bench-trim.md
quest/m0/README.md
flake.nix
bench/build/nix.nix
bench/build/nix.toml
bench/build/nix-report.jq
bench/build/nix.sh
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kixelated
changed the title
Finishes quest/m0/bench-trim.md: the build-speed benchmark costs CI only when its result can change.
Changes
bench.yml: drops the nightly schedule (about 3.5 runner-hours a night on fully pinned inputs) and theBench (moq nix)andpurejobs. It still runs on manual dispatch and on a PR that changes the harness, its workflow, thebuild-benchshell, orbench-ra-jit.bench/build/nix.{sh,nix,toml},nix-report.jq,just bench-nix, the flake'sbench-nixpackage and its now-unusedmbxinput, and the nixfmt references tonix.nix.regex.Cargo.lock, and the code only they used: thepurerule (check_graphbecomescheck_no_c) and the corpuslockfield.011402e). The pure corpora produced no README table.Choices made without asking
mbxinput since nothing else used it. #426 uses the host's mbx, not this input.lockfield instead of keeping it unused.Public API: none. Wire: none.
Checks
quest gate just cipassed locally.Models
Size: S
Implementer: Claude Code, Opus 5.5, low effort
🤖 Generated with Claude Code
(Written by Opus 5.5 with low)
Review
Rewritten by
quest reviewafter each round.01a1c3b2-5a88-7f72-bf0f-5115c32bb181, round 1Inspection found no actionable defects or apparent regressions in the remaining benchmark harness, but no builds or tests were run.