Repository navigation
feat(check): reject Required links to a later milestone - #710
Merged
Merged
Conversation
Quest-Claim: 97b318cd751f333f
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 13, 2026 23:13
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 52 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
enabled auto-merge
November 13, 2026 23:13
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
I reviewed the whole PR: the new inversions check rule, the guide and audit-skill edits, and the tests.
inversionsrule:quest checknow flags aRequiredentry whose target's root-child milestone sorts after the requirer's. It usescomparePaths, som10comes afterm9, which matches the orderranking()gets fromchildren(root). The root README and root-level files are exempt.- Fix wording: the finding offers
quest mvonly for sides that are notpermanent. When both sides are milestone READMEs, it says only to remove the link. - Guide and audit skill: the guide's
Requiredrule now covers this check, and/quest-audit's "Misaligned priorities" item is narrowed to whatquest checkcan't see. - Tests: new cases cover quests, epic READMEs, milestone READMEs on either side, m9/m10 ordering, and links that should pass. The "milestone with only blockers left" test was rebuilt so its links are no longer inverted.
bun test test/tree.test.tspasses (102 tests).
claude-opus-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Finishes
quest/m0/milestone-order.md.Summary
quest checknow fails on aRequiredentry whose target sits in a later milestone than the document listing it (src/core/rules.ts,inversions). The finding names both documents and milestones and offersquest mvof either side, or removing the link. A milestone README is never offered as the side to move. Milestones compare asquest unblockedorders them (m10afterm9). The root README and other-repository links are exempt. There is no--fix.Requiredrules (assets/AGENTS.md) state the rule./quest-audit's "Misaligned priorities" (assets/skills/audit.md) is narrowed to what check can't see. The maintainer approved both edits in quest: plan rejecting Required links to a later milestone #698.Re-scan of consumers' main (2026-11-13, this branch's check)
Decisions
The maintainer's answers (2026-11-13, /quest-run):
formatter-defaultslink: ✅ planned separately in moq's quest tree (rejected: widen quest: audit the backlog before the m0-m2 cut, and add the lab bucket moq#8637).rind's link clears when kixel-ai/rind#606 merges, and moq's six m1→m2 links clear with moq-dev/moq#8637.
Follow-ups
Requiredlinks (listed above).formatter-defaultslink.Choices made without asking
/. Epics are named by directory, matching howquest mvtakes them.(Written by Claude Opus 5.5 with low)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 3914221
Base: origin/main at b30e26f
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1d72f-2c93-7440-a66d-d69183461680, round 1Score: 9/10,
The change consistently enforces milestone ordering and handles permanent milestone READMEs appropriately, with no actionable defects found by code inspection; builds and tests were not run as instructed.Rounds: 1; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1d72f-2c93-74e2-a24b-5cffa2602217, round 1Score: 9/10,
The change consistently rejects later-milestone dependencies and handles permanent milestone documents appropriately, with no blocking defects found by code inspection, though builds and tests were not run as instructed.Rounds: 1; findings 0: fixed 0, refuted 0, open 0
Findings: none