Repository navigation
docs(skills): trim the skills and fix what transcripts show agents misread - #657
Merged
Merged
Conversation
…sread Cut sentences the CLI's own output or the guide already gives, drop guide sections a skill never uses, and reword the sentences that five days of session transcripts show agents reading two ways. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 12, 2026 10:07
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trims nine of the skills and fixes the sentences agents read two ways, from five days of this host's session transcripts (about 1,580 sessions that loaded a quest skill) and the current official skill guidance.
Changes
Composed size is what
quest skill <name>prints: the skill, the skills it builds on, and its guide sections. Claude Code keeps only the first 5,000 tokens (about 20k characters) of an invoked skill after compaction, so a coordinator that compacts was losing the tail of its guide sections.Cut, because the CLI or the guide already says it:
quest startbuilds the claim on the fetched upstream, and thegit pull && quest startchain it invited was refused by the worktree hook in about 28 sessions), and the restatements of the guide's Execution section.--helppointers (quest review --helpis 25k characters, and 36 of 136 sessions ran it throughhead), and the findings loop that each round'snextline already directs.quest land, ungated base), whichquest merge's refusals spell out.quest-plan/<slug>branch, the open-PR overlap check, and what a brief holds.Reworded, because sessions read them two ways:
gh pr readyis named for it (120 of 136 sessions had to work that out).--branchis passed whenever the checked-out branch is not the PR's head branch (15 sessions lost their record torecord skipped). The## Modelslines are shown (12 sessions in two days searched other PRs for the format). Either reviewer's outage stops the review (4 sessions on 2026-11-12 split four ways when only the second reviewer failed)./quest-reviewonce nothing is open, draft or ready, and a plainquest reviewround only when stopping early on a ready PR. Of 185 sessions on a ready PR, 85 took one reading and 68 the other.checks_pending, a reason no code prints any more, becomeschecks_timed_out, which sent a green PR back to the user; it is retried once.## Waiting. 11 sessions marked a PR ready with decisions open.Left alone:
afk,complete,spawn,delete,export,recurring(no evidence against their current text), andunblock, which moq-dev/quest#649 folds intocomplete.Public API and wire impact
Shipped skill text changes; no CLI, format, or wire change. Descriptions are unchanged, so no stub changes.
Validation
just checkandjust testpass (1,248 tests).quest skill <name>for all 16 skills, with the sizes above. A scan of each composed output confirms every guide section a skill names by "the guide's X section" is still loaded with it.Choices made without asking
assets/AGENTS.md) is untouched: the request was for the skills. The largest remaining weight is there, below.Follow-ups
/quest-mergedescribes by hand with one rule, runquest mergewith aquestthe PR cannot modify. No open decisions.Not planned here, for the maintainer to weigh:
quest agentran in 2 of 107 coordinator sessions, and its paragraph is 1.1k characters in every coordinator's context./quest-spawnwith no filter starts every ready quest in any milestone. One session walked into m3 with about 290 ready and was stopped by the user.Caused by
No single PR: the wording accumulated across the skills' history.
Models
Size: L
Implementer: Claude Code, claude-fable-5-2, unknown effort
🤖 Generated with Claude Code
(Written by Claude Fable 5)
Review
Rewritten by
quest reviewafter each round.Head: b95eadc
Base: origin/main at 907aeac
Reviewer: Codex, gpt-6.1-sol, xhigh effort
Session:
01a1cf1f-147b-7361-8bdd-91c26d16b40a, round 2Score: 10/10,
Static review of the incremental documentation changes and supporting CLI code found no actionable regressions.Findings: none
Reviewer: opencode, opencode-go/deepseek-v4.1-flash, high effort
Session:
ses_e30e0e636ffeKzua9yGMuedg1N, round 2Score: 10/10,
Every earlier finding is fixed at the head, including the follow-up quest's trusted-binary rule and the bounded timeout retry, and no new problem is introduced.Findings: none
The last round's findings, at 1bfc937:
quest/m0/token-waste/merge-check.md:28:The follow-up quest's plan drops the trusted-binary requirement for the head check;The quest's Plan now says the check is only as trusted as the `quest` that runs it and keeps the rule that `quest merge` must run with a `quest` the PR cannot modify, with a bullet weighing a refusal from the head's checkout, so the earlier bypass is closed.assets/skills/run.md:30:Falling to the next model on any error contradicts the guide and README;run.md:30 restores the original fallback to a missing or logged-out CLI or a usage limit with nothing written, which agrees with the guide's Coordination and README.md:1277-1281.assets/skills/merge.md:24:Under /quest-run, follow-up questions are asked twice;merge.md:24 now asks only about follow-ups the pick round has not asked and runs `/quest-iterate` with that round's answers, so `/quest-run` no longer re-asks questions it already put to the user.assets/skills/run.md:60:`checks_timed_out` is retried without a bound;run.md:60 retries a `checks_timed_out` head once and leaves a second timeout of the same head to the user, bounding the re-queue loop.assets/skills/import.md:14:"Comment once" conflicts with the second comment at merge start, and the PR link is gone;import.md now gives each issue exactly one comment, posts a tracked issue's comment at merge start and a won't-fix one at close, and links both the quest and the PR.assets/skills/review.md:58:A reviewer that took no hold is still told to release a token;review.md:58 now conditions the release on having taken a hold, so the no-hold path is no longer told to run `quest release` without a token.assets/skills/run.md:3:run drops the Prompting guide section although it writes every delegation brief;run.md:13 now carries the Prompting rules that apply to a brief, setting settled decisions apart from recommendations, naming the task's reason and context, and forbidding prescribed steps and restated rules, leaving only instruction-file rules in the section.assets/skills/iterate.md:28:`--branch` is only paired with a detached checkout in iterate;iterate.md:28 now passes `--branch <head-branch>` whenever the checked-out branch is not the PR's head branch, matching review.md:15.