Skip to content

docs(context): confirm a Caused by culprit in its diff - #653

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/caused-by-culprits
Nov 12, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/caused-by-culprits

Conversation

@kixelated

@kixelated kixelated commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/caused-by-culprits.md, from the mistake audit: 4 of 14 moq-dev/moq ## Caused by links named a PR that only touched the lines, deferred the work, or kept older behavior.

Changes

  • assets/CONTEXT.md: the Caused by rule now asks to confirm in the blamed PR's diff that it introduced the defect, not merely touched the lines, deferred the work, or kept older behavior; otherwise say no single PR caused it. CONTEXT.md is 9,187 of 10,000 characters.
  • Deletes the quest and rewrites its link in quest/m0/mistake-audit.md.

Choices made without asking

  • Extended the existing sentence rather than adding a rule. I left out "follow blame further back" because blame already finds the earlier PR once the reader rules out the last one.

Public API

None.

Validation

This is a prose rule with no behavior to exercise. quest check --base origin/main, just check, and just test pass.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 678daee

  • Base: origin/main at 93c9c2e

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1ce89-900d-7933-9aed-f1d246fad62a, round 2

  • Score: 10/10, The incremental wording clarifies culprit tracing without introducing actionable defects; builds and tests were not run as instructed.

  • Findings: none

  • Reviewer: opencode, opencode-go/deepseek-v4.1-flash, high effort

  • Session: ses_e31766a4dffeEcPmOaYG03I8Gt, round 2

  • Score: 10/10, The head adds the missing trace-further-back step and confines a Plan-named culprit to one confirmed in its diff, all within the hook's 10,000-character budget, so no finding holds.

  • Findings: none

  • The last round's findings, at be25373:

    • Fixed: medium, assets/CONTEXT.md:76: The reworded rule drops the "follow blame further back" path, so a real culprit becomes "no single PR"; assets/CONTEXT.md:76 now says the culprit is confirmed to introduce the defect "else traced further back with blame", so a rename or refactor PR that blame names is followed further back instead of forcing "no single PR caused it".
    • Fixed: low, assets/skills/plan.md:28: The plan skill still tells implementers to list a Plan-named culprit without confirming it; assets/CONTEXT.md:76 now covers the Plan channel directly, listing a PR "named in its quest's Plan, and confirmed in that PR's diff to introduce the defect", and CONTEXT.md loads for every task, so the plan.md line's "without searching again" no longer lets an unconfirmed Plan-named culprit through.
    • Refuted: low, assets/CONTEXT.md:76: The rule grew to 85 words in the always-loaded file for a redundant clause; The named cases are recorded failure classes, not a restatement: quest/m0/mistake-audit.md:138-140 records the 4 moq-dev/moq culprits that "deferred the work, or kept older behavior", the deleted quest's Plan recorded the blame-last-toucher class (4 of 14), and the file is 9,254 characters against the 10,000-character limit AGENTS.md:3 sets.

kixelated and others added 2 commits November 11, 2026 22:51
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Caused by names only the PR that shipped the defect docs(context): confirm a Caused by culprit in its diff Nov 12, 2026
…-named one

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 12, 2026 07:07
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b1b1d719-cfa8-42a2-bf17-1604cfeb2748
Commits

Reviewing files that changed from the base of the PR and between 93c9c2e and 678daee.

Files selected for processing: 3

  • assets/CONTEXT.md
  • quest/m0/caused-by-culprits.md
  • quest/m0/mistake-audit.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 1df06c9 Nov 12, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m0/caused-by-culprits branch November 12, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant