Repository navigation
docs(context): confirm a Caused by culprit in its diff - #653
Merged
Merged
Conversation
Quest-Claim: a924fa83b472499b
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-named one Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 12, 2026 07:07
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 30 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes
quest/m0/caused-by-culprits.md, from the mistake audit: 4 of 14 moq-dev/moq## Caused bylinks named a PR that only touched the lines, deferred the work, or kept older behavior.Changes
assets/CONTEXT.md: the Caused by rule now asks to confirm in the blamed PR's diff that it introduced the defect, not merely touched the lines, deferred the work, or kept older behavior; otherwise say no single PR caused it. CONTEXT.md is 9,187 of 10,000 characters.quest/m0/mistake-audit.md.Choices made without asking
Public API
None.
Validation
This is a prose rule with no behavior to exercise.
quest check --base origin/main,just check, andjust testpass.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.Head: 678daee
Base: origin/main at 93c9c2e
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1ce89-900d-7933-9aed-f1d246fad62a, round 2Score: 10/10,
The incremental wording clarifies culprit tracing without introducing actionable defects; builds and tests were not run as instructed.Findings: none
Reviewer: opencode, opencode-go/deepseek-v4.1-flash, high effort
Session:
ses_e31766a4dffeEcPmOaYG03I8Gt, round 2Score: 10/10,
The head adds the missing trace-further-back step and confines a Plan-named culprit to one confirmed in its diff, all within the hook's 10,000-character budget, so no finding holds.Findings: none
The last round's findings, at be25373:
assets/CONTEXT.md:76:The reworded rule drops the "follow blame further back" path, so a real culprit becomes "no single PR";assets/CONTEXT.md:76 now says the culprit is confirmed to introduce the defect "else traced further back with blame", so a rename or refactor PR that blame names is followed further back instead of forcing "no single PR caused it".assets/skills/plan.md:28:The plan skill still tells implementers to list a Plan-named culprit without confirming it;assets/CONTEXT.md:76 now covers the Plan channel directly, listing a PR "named in its quest's Plan, and confirmed in that PR's diff to introduce the defect", and CONTEXT.md loads for every task, so the plan.md line's "without searching again" no longer lets an unconfirmed Plan-named culprit through.assets/CONTEXT.md:76:The rule grew to 85 words in the always-loaded file for a redundant clause;The named cases are recorded failure classes, not a restatement: quest/m0/mistake-audit.md:138-140 records the 4 moq-dev/moq culprits that "deferred the work, or kept older behavior", the deleted quest's Plan recorded the blame-last-toucher class (4 of 14), and the file is 9,254 characters against the 10,000-character limit AGENTS.md:3 sets.