Skip to content

quest land: a failed fixer's handback quotes the gate's failure - #627

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/queue-watcher/fixer-crash-quotes-gate
Nov 11, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/queue-watcher/fixer-crash-quotes-gate

Conversation

@kixelated

@kixelated kixelated commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

When the land fixer fails for its own reasons (crash, refused launch, timeout, invalid result, or any refusal), its handback comment now quotes the gate's failing check output instead of the tail of the fixer's own log. The comment's reason still names the fixer's error (fixer crashed (exit 3), fixer timed out, ...). A fixer that hands back citing log lines still quotes those lines.

Both handback paths, quest land's collector and quest land watch's, share one helper, handbackLog in src/cli/land-fixer.ts, which replaces cited and fixerLog.

Tests: the quest land crash, refusal, and invalid-result handbacks, the watcher's crash handback, and the diagnostics test each assert that the gate's failure is quoted (escaped) and that the fixer's output is not.

Finishes and deletes quest/m0/queue-watcher/fixer-crash-quotes-gate.md.

Choices made without asking

  • The fixer's own output no longer reaches the comment at all. It stays in the job log on the host (fix-job-*.json.log), which the diagnostics test still checks. Quoting both would bring back the noise this quest removes, such as a wrapper's Broken pipe hiding the real cause.
  • A fixer handback that cites no lines now quotes the gate's log too (it used to quote the fixer's tail).

Public API

None. Only the handback comment's quoted log changes.

Caused by

Follow-ups

None.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, low effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with low)

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, medium effort
  • Session: 01a1ca3f-cfdd-7131-a3a4-cb4343662917, round 1
  • Head: 5b82f7b
  • Base: origin/main at 5055d0c
  • Score: 9/10, The change consistently quotes gate failures when the fixer fails while preserving explicit citations and host diagnostics; no actionable defects were found by code inspection, though builds and tests were not run as instructed.
  • Findings: none

kixelated and others added 3 commits November 11, 2026 00:53
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title A failed fixer still hands back the gate's failure quest land: a failed fixer's handback quotes the gate's failure Nov 11, 2026
@kixelated
kixelated marked this pull request as ready for review November 11, 2026 10:56
@coderabbitai

coderabbitai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 91625a0a-6643-4ac3-991d-892925e84dea
Commits

Reviewing files that changed from the base of the PR and between f3301ef and 5b82f7b.

Files selected for processing: 6

  • quest/m0/queue-watcher/fixer-crash-quotes-gate.md
  • src/cli/land-fixer.ts
  • src/cli/land-watch-fix.ts
  • test/land-fixer-diagnostics.test.ts
  • test/land-watch.test.ts
  • test/land.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 8b2bb4e Nov 11, 2026
23 checks passed
@kixelated
kixelated deleted the quest/m0/queue-watcher/fixer-crash-quotes-gate branch November 11, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant