Repository navigation
quest land: a failed fixer's handback quotes the gate's failure - #627
Merged
Merged
Conversation
Quest-Claim: 4f40924e39d55490
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 11, 2026 10:56
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the land fixer fails for its own reasons (crash, refused launch, timeout, invalid result, or any refusal), its handback comment now quotes the gate's failing check output instead of the tail of the fixer's own log. The comment's reason still names the fixer's error (
fixer crashed (exit 3),fixer timed out, ...). A fixer that hands back citing log lines still quotes those lines.Both handback paths,
quest land's collector andquest land watch's, share one helper,handbackLoginsrc/cli/land-fixer.ts, which replacescitedandfixerLog.Tests: the
quest landcrash, refusal, and invalid-result handbacks, the watcher's crash handback, and the diagnostics test each assert that the gate's failure is quoted (escaped) and that the fixer's output is not.Finishes and deletes
quest/m0/queue-watcher/fixer-crash-quotes-gate.md.Choices made without asking
fix-job-*.json.log), which the diagnostics test still checks. Quoting both would bring back the noise this quest removes, such as a wrapper'sBroken pipehiding the real cause.Public API
None. Only the handback comment's quoted log changes.
Caused by
Follow-ups
None.
Models
Size: S
Implementer: Claude Code, claude-opus-5-5, low effort
🤖 Generated with Claude Code
(Written by Claude Opus 5.5 with low)
Review
Rewritten by
quest reviewafter each round.01a1ca3f-cfdd-7131-a3a4-cb4343662917, round 1The change consistently quotes gate failures when the fixer fails while preserving explicit citations and host diagnostics; no actionable defects were found by code inspection, though builds and tests were not run as instructed.