Skip to content

quest: plan CPU-time test timeouts, gate test races, and Claude's sandbox control - #609

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/test-followups
Nov 10, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/test-followups

Conversation

@kixelated

@kixelated kixelated commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Plans three follow-ups from /quest-complete on 2026-11-10.

  • quest/m0/test-cpu-timeout.md (M): unit tests time out on CPU time, with a wall-clock bound only for hangs. 5 of the last 8 failed merge-group builds here failed only on vitest's 5 s wall-clock default under host load, dropping moq-dev/quest#602, moq-dev/quest#595 and moq-dev/quest#598 today.
  • quest/m0/gate-test-races.md (S): two intermittent test/gate.test.ts assertion failures, one in a merge-group build and one in moq-dev/quest#596's local run.
  • quest/m1/claude-control-helper.md (S): the Claude Code control in just review-sandbox no longer fires its planted apiKeyHelper, found by moq-dev/quest#603.

Decisions

Each is also in its quest's Plan.

  • Claude control goal: ✅ one quest so the control passes and keeps only plants Claude Code runs (rejected: drop it to the next model check).
  • Claude control approach: ✅ find the release behavior first, run the control in a configuration where the helper fires, drop the plant only if none exists (rejected: drop the plant; accept a failing control).
  • Claude control milestone: ✅ m1, beside the model check (rejected: m0, m2).
  • Timeout goal: ✅ one quest, fixed at the cause rather than by raising timeouts (rejected: no quest).
  • Timeout approach: ✅ a CPU-time watchdog per test plus a wall-clock hang bound (rejected: a generous wall testTimeout as a hang bound only, which the agent recommended; keep 5 s and reduce the queue build's load). The user reframed these as load-triggered timeouts, not flakes. The hang bound stays because a hung test spends no CPU.
  • Gate races: ✅ a separate quest (rejected: fold into the timeout quest; leave it to the flaky-test watcher).
  • Milestone for both test quests: ✅ m0 (rejected: m1).

Follow-ups

None.

Impact

Public API: none. Wire: none. Only quest/ changes.

Validation

quest check passes (35 documents). No code changed.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, medium effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with medium)

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, medium effort
  • Session: 01a1c6bc-87a1-77d2-83aa-a0da83afcb17, round 1
  • Head: 64c5353
  • Base: origin/main at 9f73a23
  • Score: 10/10, The diff adds only three planning documents with clear scope and valid local references, with no runtime changes or actionable defects identified.
  • Findings: none

…dbox control

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog

pullfrog Bot commented Nov 10, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

@kixelated
kixelated marked this pull request as ready for review November 10, 2026 18:33
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ebc5ecaf-bfb4-4c8e-89aa-33bad6c27f7c
Commits

Reviewing files that changed from the base of the PR and between 9f73a23 and 64c5353.

Files selected for processing: 3

  • quest/m0/gate-test-races.md
  • quest/m0/test-cpu-timeout.md
  • quest/m1/claude-control-helper.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated added this pull request to the merge queue Nov 10, 2026

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head: 64c5353

No actionable findings in these three planning documents. The timeout work retains a wall-clock hang bound alongside the CPU budget, the gate assertion races remain a separate investigation, and the Claude control plan requires establishing when the plant actually fires before removing it. The local Related links resolve to the new companion quests or existing plans.

Overall direction: the scopes and acceptance goals are clear, with implementation choices and prior decisions distinguished. These documents do not implement the fixes.

Verification limits: GitHub-only static review of the plans and linked local context. No quest check, tests, builds, live Claude experiment or historical CI-log verification performed.

(Written by review (OpenAI))

Merged via the queue into main with commit 860425e Nov 10, 2026
11 checks passed
@kixelated
kixelated deleted the quest-plan/test-followups branch November 10, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant