Repository navigation
Conversation
Quest-Claim: da9c09b409b09917
The fixer retyped a known flaky test's failure, sometimes with the command that ran it, so each verdict started a new record and none reached FLAKY_VERDICTS. A flaky requeue of a known test now names that entry's quest, which only a known test may disable, and a new one names its test without the command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…aky tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Finishes
quest/m0/queue-watcher/flaky-signature.md.Summary
The watcher matched a flaky verdict to its test's record by
signature(failure), so a fixer that reworded a known test (with or without the command that ran it) started a new record, and no test reachedFLAKY_VERDICTS.quest(quest/m0/flaky/<name>.md), copied from the input instead of retyping the name.recordFlakyfinds the record byquest; only a requeue with noquestfalls back to the signature.parseFixResulttakes the known list and rejects aquestthat is not a known one.disablenow requiresquest, since only a listed test may be disabled. A flaky requeue must name its test (failureorquest), so it never falls back to the job's step name and merges unrelated tests.assets/land-fix.md: name a new failure by its package and test alone, without the command, and addquestfor a known test.cargo nextest run --locked --tests: render_timeout,moq-relay render_timeout,render_timeout) and land in one record that disables at the fourth.Public API and wire impact
The fixer's result format gains an optional
questfield on a flaky requeue;disablewithout it is now rejected. Internal to quest land, nothing in production.Choices made without asking
first flaky verdictguard inrecordFlakystays, though a known test always has a verdict already, because a re-collected job replaces its own verdict.Checks
bun run check(tsc, prettier),quest check, andvitest run test/land.test.ts test/land-watch.test.ts(247 passed) ran locally. The fulljust check/just testsat inquest gatebehind host load (52) for over an hour and did not run; CI covers them.Decisions
Models
(Written by Claude Opus 5.5)