Skip to content

quest: plan quest setup installing the worktree hooks - #559

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/setup-worktree-hooks
Nov 7, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/setup-worktree-hooks

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Plans the follow-up moq-dev/quest#556 suggested. The coordinator decided it from evidence, as the maintainer asked follow-ups to be handled.

[S] quest/m0/setup-worktree-hooks.md (m0): quest setup gains an opt-in for the Claude Code worktree hooks, and the README's pasted hook JSON goes away.

Today Quest installs user-level hooks two ways:

  • quest setup writes the rule hooks from the HOOKS table (moq-dev/quest#517).
  • Users paste the worktree hooks from the README.

#556 added two worktree events, so every user had to re-paste. moq-dev/quest#544 had to guard each pasted command against a missing quest. One installer fixes both, and it fits Quest's re-scope as internal tooling.

Validation

  • quest check (built from main): 72 documents ok

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort

Review

Skipped: one new quest file, with no code changes.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog

pullfrog Bot commented Nov 7, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

@kixelated
kixelated enabled auto-merge November 7, 2026 22:21
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3a99e684-36bc-4f58-bcb8-c3e0ebbd7952
Commits

Reviewing files that changed from the base of the PR and between 2108b1d and c54da1a.

Files selected for processing: 1

  • quest/m0/setup-worktree-hooks.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated added this pull request to the merge queue Nov 7, 2026

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head c54da1a against base 2108b1d.

Findings: No actionable issues found in the complete 33-line addition to quest/m0/setup-worktree-hooks.md. This PR records a plan; it does not change the installer or runtime hooks.

Direction: Consolidating installation in quest setup, with worktree behavior explicitly opt-in and existing Quest entries replaced rather than duplicated, is consistent with the current user-level hook design. The implementation should preserve both rule and worktree handling on shared events, plus the session-end timeout introduced by moq-dev/quest#556.

Scope and limits: GitHub-only static review of the full changed file, the existing src/cli/hooks.ts installer, the relevant README instructions, and #556's proposed hook additions. No shell commands, tests, or quest check were run; the PR's reported validation was not independently reproduced. Rechecked the open, non-draft state, full head/base SHAs, and existing reviews immediately before posting. This is a COMMENT review, not approval or a merge-readiness claim.

(Written by review (OpenAI))

Merged via the queue into main with commit e88f7a1 Nov 7, 2026
6 checks passed
@kixelated
kixelated deleted the quest-plan/setup-worktree-hooks branch November 7, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant