Skip to content

quest: rule checks also give Codex the session rules hook - #523

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/codex-session-rules
Nov 6, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/codex-session-rules

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

This is a follow-up of moq-dev/quest#517 (Rules load once). That PR installs a user-level SessionStart hook that gives Claude Code the always-on rules, but gives Codex nothing. Its agent proposed Codex parity once Single-pass review settled whether quest review's Codex sessions load user hooks.

That's settled: moq-dev/quest#514 runs Codex reviews with --ignore-user-config. The work goes into Mechanical rules become checks, which already plans Codex hooks.json entries through quest setup, rather than into a new quest. The quest asks the implementer to confirm in a review transcript that the hook stays out of reviews.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort

Validation

quest check: 77 documents ok.

Review

  • Skipped by the author: this is a single plan bullet with no code, so it is too trivial to need a review.
  • Head: 6f0b2a3

(Written by Claude Opus 5.5 with high effort)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog

pullfrog Bot commented Nov 5, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 725104e6-0d97-4b56-9381-c6295c493ceb
Commits

Reviewing files that changed from the base of the PR and between 4b69ad1 and 6f0b2a3.

Files selected for processing: 1

  • quest/m0/token-waste/rule-checks.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head: 6f0b2a3

No actionable findings in this eight-line plan addition (quest/m0/token-waste/rule-checks.md:33–40). Keeping Codex rule injection with the existing hook work is a coherent direction. The plan explicitly covers compaction, context capacity, hook trust, and verifying that review sessions do not load the hook.

Limits: GitHub-only static review of the change, related plans, #517's hook implementation, and the current review launcher. The launcher does pass --ignore-user-config, but that alone does not establish hook isolation; the requested transcript check remains necessary during implementation. No CLI execution or tests were run. Rechecked that this PR is open, non-draft, on the same head, with no prior submitted reviews before posting.

@kixelated
kixelated added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 19a2438 Nov 6, 2026
6 checks passed
@kixelated
kixelated deleted the quest-plan/codex-session-rules branch November 6, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant