Repository navigation
Conversation
Quest-Claim: a63b5bfe530b84fd
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claims quest/m0/release-qmux-credit.md. The work itself is the
releasebackport moq-dev/moq#8808 (qmux0.5.4,@moq/qmux^0.3.5,@moq/net0.4.8); this PR is the main-side checkpoint, as in moq-dev/moq#7596. It removes the clearedqmux0.5.4 /@moq/qmux0.3.5 publication wait (both confirmed published) and records what remains.Summary
Maintainer:wait names the merge and cut that only they can do (a merge toreleasepublishes).Decisions
Taken on my recommendation (headless run); each is undoable in review:
@moq/netto 0.4.8 in fix(qmux): return stopped-stream receive credit, qmux 0.5.4 and @moq/qmux 0.3.5 (backport) #8808 (recommended): the^0.3.5requirement and two merged but unpublished@moq/netbackports (fix(net): backport reading a 64-bit Hop ID as unknown to release #8035, fix(net): backport GOAWAY loopback refusal for every IPv4 spelling #8346) only reach npm with a bump. Alternative: drop the two version lines and bump at the cut.@moq/qmux's own credit tests (fail on 0.3.3, pass on 0.3.5) because an end-to-end@moq/netviewer stall could not be forced on loopback. Alternative: a viewer over a delayed link.Impact
Quest documents only. No public API or wire change here; #8808 reports its own (none).
Validation
quest check --base origin/main: 525 documents ok. Behavior is exercised on #8808: the publisher direction fails on 0.5.3 after 7 to 9 mid-group cancels and passes 120 on 0.5.4.Review
Skipped: this PR only edits a quest. The backport #8808 has a local review:
quest review --base origin/release, Codex gpt-6.1-sol medium with a low shadow, no findings, score 9/10, on headb834502dfa46.Waiting
@moq/net0.4.8 bump (recommended: keep) and whether the viewer-side validation is enough (recommended: yes, the qmux tests are the differential).Models
Size: S
Implementer: Claude Code, claude-sonnet-5-5, unknown effort (arm B)
🤖 Generated with Claude Code
(Written by Claude Sonnet 5.5)