Skip to content

fix(demo): play an inherited stereo name as mono, and stage the VR harness's binaries - #8790

Merged
kixelated merged 1 commit into
mainfrom
vr-demo/review-fixes
Nov 15, 2026
Merged

kixelated merged 1 commit into
mainfrom
vr-demo/review-fixes

Conversation

@kixelated

@kixelated kixelated commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

CodeRabbit's four findings on moq-dev/moq#8781 arrived while it sat in the merge queue, which refused pushes to its branch, so their fixes land here.

  • demo/vr checked stereo in PACKING, so a catalog stereo of "constructor" or "toString" (any string is allowed, unknown ones read as absent) passed and made #build() throw.
  • just test vr ran the relay and CLI from target/, which a clean in another shell could remove mid-run.
  • The docs didn't say the demo decodes ambisonics at first order, and the headset quest didn't say how the headset reaches the relay.

Approach

  • Object.hasOwn(PACKING, stereo), so an inherited name plays as mono like any unknown packing.
  • harness_stage both binaries right after the build and run them from $HARNESS_RUN/bin, as the interop and compat harnesses do.
  • doc/bin/demo.md: a higher order plays only its first four channels. quest/m1/vr-demo-try.md: forward the relay port too, or point the page at the relay with ?url=.

Validation

  • just test vr passes: {"projection":{"kind":"equirectangular","fov":180},"stereo":"left-right","layout":"ambisonic","channels":4} laid out; ahead L 0.313 R 0.090, facing L 0.188 R 0.161.
  • just ci passes.

Impact

None: a demo, a test harness, docs, and a quest.

Alternatives

None worth noting.

Caused by

  • moq-dev/moq#8781 - checked the stereo packing with in, ran the harness binaries unstaged, and left the first-order limit and relay reachability unsaid (found by reviewer)

Follow-ups

None.

Models

Size: XS
Implementer: Claude, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 3870ee4

  • Base: origin/main at 5f6ee63

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1dda1-538f-72e2-b7ab-0dfb13d845a4, round 1

  • Score: 9/10, Source review found no actionable regressions in the focused stereo-check and staged-binary changes, but builds and tests were not run as instructed.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

…rness's binaries

Also say the demo decodes ambisonics at first order, and how a headset reaches
the relay.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 24 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8e7711ea-b0b1-4833-a375-a0f19b4d8ac9
Commits

Reviewing files that changed from the base of the PR and between 5f6ee63 and 3870ee4.

Files selected for processing: 4

  • demo/vr/src/scene.ts
  • doc/bin/demo.md
  • quest/m1/vr-demo-try.md
  • test/vr/run.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 15, 2026 05:15

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — the single commit, across all four files.

  • Stereo check — Object.hasOwn(PACKING, stereo) replaces in, so inherited names like "constructor" play as mono.
  • Harness staging — test/vr/run.sh stages moq-relay and moq right after the build with harness_stage, then runs them from $HARNESS_RUN/bin. This matches the call shape in interop.sh and compat.sh.
  • Docs and quest — doc/bin/demo.md notes the first-order ambisonic limit, and quest/m1/vr-demo-try.md explains how the headset reaches the relay.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit e365b25 Nov 15, 2026
7 checks passed
@kixelated
kixelated deleted the vr-demo/review-fixes branch November 15, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant