Repository navigation
fix(demo): play an inherited stereo name as mono, and stage the VR harness's binaries - #8790
Merged
Merged
Conversation
…rness's binaries Also say the demo decodes ambisonics at first order, and how a headset reaches the relay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
enabled auto-merge
November 15, 2026 05:15
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — the single commit, across all four files.
- Stereo check —
Object.hasOwn(PACKING, stereo)replacesin, so inherited names like"constructor"play as mono. - Harness staging —
test/vr/run.shstagesmoq-relayandmoqright after the build withharness_stage, then runs them from$HARNESS_RUN/bin. This matches the call shape ininterop.shandcompat.sh. - Docs and quest —
doc/bin/demo.mdnotes the first-order ambisonic limit, andquest/m1/vr-demo-try.mdexplains how the headset reaches the relay.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
CodeRabbit's four findings on moq-dev/moq#8781 arrived while it sat in the merge queue, which refused pushes to its branch, so their fixes land here.
demo/vrcheckedstereo in PACKING, so a catalogstereoof"constructor"or"toString"(any string is allowed, unknown ones read as absent) passed and made#build()throw.just test vrran the relay and CLI fromtarget/, which a clean in another shell could remove mid-run.Approach
Object.hasOwn(PACKING, stereo), so an inherited name plays as mono like any unknown packing.harness_stageboth binaries right after the build and run them from$HARNESS_RUN/bin, as the interop and compat harnesses do.doc/bin/demo.md: a higher order plays only its first four channels.quest/m1/vr-demo-try.md: forward the relay port too, or point the page at the relay with?url=.Validation
just test vrpasses:{"projection":{"kind":"equirectangular","fov":180},"stereo":"left-right","layout":"ambisonic","channels":4} laid out; ahead L 0.313 R 0.090, facing L 0.188 R 0.161.just cipasses.Impact
None: a demo, a test harness, docs, and a quest.
Alternatives
None worth noting.
Caused by
in, ran the harness binaries unstaged, and left the first-order limit and relay reachability unsaid (found by reviewer)Follow-ups
None.
Models
Size: XS
Implementer: Claude, claude-opus-5-5, unknown effort
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.Head: 3870ee4
Base: origin/main at 5f6ee63
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1dda1-538f-72e2-b7ab-0dfb13d845a4, round 1Score: 9/10,
Source review found no actionable regressions in the focused stereo-check and staged-binary changes, but builds and tests were not run as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none