Repository navigation
quest(m2/audio-playout): replay the publisher's largest group at tune-in - #8789
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Derive the read's settle once per read and race it with race(), so each pass adds no listener to the outstanding read. The replay quest no longer waits on #8761, which merged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 15, 2026 05:36
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the full diff (2 files, 3 commits).
- Backlog test helper:
consumer.backlog.test.tsswapsPromise.racefor the scopedracefrom@moq/signals. It derives the read's settle (.then(() => true)) once per read, so each pass adds no listener to it.raceexists and is exported fromjs/signals/src/index.ts, and the call shape matches. - New quest:
quest/m2/audio-playout/replay-largest.mdplans thelargestfield (trace version 4), its capture and derivation, the replay subscriber wrapper, and the budget updates. It is internally consistent and scoped to the epic.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The audio-quality replay can't measure #8761's backlog reports. Its local track learns its largest group from the first group to land, which for
relay-mic-rtt40is the stale tune-in frame (group 7499). That sits below the backlog the consumer closes, so the replay reports nothing and the row still reads 320 ms. CodeRabbit also flagged aPromise.racein #8761's backlog test helper that the repo's guideline says to replace with the scopedracehelper.Approach
quest/m2/audio-playout/replay-largest.mdunder the audio-playout epic, with every decision settled:largest(version 4).relay-mic-rtt40).js/hang/src/container/consumer.backlog.test.ts(from feat(hang,moq-mux,moq-audio): both consumers report the join's backlog they skip #8761, now onmain) races its outstanding read with the scopedracefrom@moq/signalsinstead ofPromise.race. It derives the read's settle once per read, so each pass adds no listener to it.Decisions
largestrather than re-record them. Re-recording needs a person at the MacBook's microphone and would move every column of the baseline. Measured locally with the derived 8994,relay-mic-rtt40reads target p95 120 ms (from 320); group 9047 (the whole backlog) measures the same row.largest()rather than adding API to@moq/netor the consumer, or creating an empty group head the recording never saw.Impact
None at runtime: a quest plan and a test helper.
Validation
quest check --base origin/mainjust checkbun test src/container/consumer.backlog.test.ts: 5 passquest review --harness codex): no findingsModels
Size: XS
Implementer: Claude, claude-opus-5-5, unknown effort
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)