Skip to content

quest: move the open test flakes children to a fresh epic - #8776

Merged
kixelated merged 2 commits into
mainfrom
quest-complete/test-flakes-2
Nov 15, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest-complete/test-flakes-2

Conversation

@kixelated

@kixelated kixelated commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Retires the finished quest/m0/test-flakes-2 epic: its own work was done 2026-11-13 and its last child landed in moq-dev/moq#8718. moq-dev/moq#8764 then added two open children (mux-consumer-clock, listing-yield), so they move, with a new README, to a fresh quest/m0/test-flakes-3/ epic instead of closing an epic that still has children.

Maintainer's pick (2026-11-15): merge with the reworded rule. A new flake joins the open epic; once it completes, the next flake opens a fresh one. The root README rule now links test-flakes-3; the ci, nightly and interop-green mentions are unlinked.

Impact

No public API or wire impact; quest docs only.

Validation

quest check --base origin/main: 509 documents ok. quest gate just check passed. No behavior to exercise.

Review

Rewritten by quest review after each round.

  • Head: 92afce1

  • Base: origin/main at c3682ea

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1dd80-e7a4-7501-af5e-d5ce331d2c1d, round 1

  • Score: 10/10, The diff only reorganizes quest documentation, preserves both outstanding flake plans, and updates references without changing runtime behavior; no actionable defects were found.

  • Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Models

Size: S
Implementer: Claude, claude-sonnet-5-5, unknown effort

(Written by Sonnet 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 14, 2026 22:49
pullfrog[bot]
pullfrog Bot previously approved these changes Nov 14, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the full diff of the single commit.

  • Epic deleted: quest/m0/test-flakes-2/README.md is removed.
  • Links unlinked: quest/README.md, ci, interop-green and nightly now use plain text. A repo grep finds no remaining test-flakes-2 references.
  • Flake rule reworded: the root rule now says "planned anew when none is open", as the PR's Decisions section states.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request deletes the test-flakes-2 quest README and adds a test-flakes-3 README with epic rules and guidance. It updates references to the test-flakes epic in four other README files. One change makes planning an epic conditional on recurrence of the macOS receive_credit timeout.

Merge Risk: Minimal · up to 92afc

This change only reorganizes quest documentation and updates links and wording about the test-flakes epic. It has no runtime or API impact, so the risk of merging is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title names the main change: open test-flake children move from the finished test-flakes-2 epic to a fresh test-flakes-3 epic. The changeset matches this, since it renames listing-yield.md and mux…
Description check Passed The description states the purpose: it retires the finished test-flakes-2 epic and moves its two open children to a new test-flakes-3 epic. It also covers the rule rewording, impact, and validation. T…
Full details: Title check

Explanation

The title names the main change: open test-flake children move from the finished test-flakes-2 epic to a fresh test-flakes-3 epic. The changeset matches this, since it renames listing-yield.md and mux-consumer-clock.md into test-flakes-3, adds its README, and deletes test-flakes-2.

Full details: Description check

Explanation

The description states the purpose: it retires the finished test-flakes-2 epic and moves its two open children to a new test-flakes-3 epic. It also covers the rule rewording, impact, and validation. This matches the changeset.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bbb879ea-ae8d-4b0f-ae87-21bd032e0afa
Commits

Reviewing files that changed from the base of the PR and between 758bcd6 and 92afce1.

Files selected for processing: 8

  • quest/README.md
  • quest/m0/ci/README.md
  • quest/m0/interop-green/README.md
  • quest/m0/nightly/README.md
  • quest/m0/test-flakes-2/README.md
  • quest/m0/test-flakes-3/README.md
  • quest/m0/test-flakes-3/listing-yield.md
  • quest/m0/test-flakes-3/mux-consumer-clock.md
Files with no reviewable changes: 2

  • quest/m0/test-flakes-2/README.md
  • quest/m0/test-flakes-3/listing-yield.md
Files skipped from review as they are similar to previous changes: 3

  • quest/m0/ci/README.md
  • quest/m0/interop-green/README.md
  • quest/m0/nightly/README.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

…akes-3 epic

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title quest: delete the finished test flakes epic quest: move the open test flakes children to a fresh epic Nov 15, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the delta since the prior review: the merge of main and the move of the open flake children.

  • Created test-flakes-3 epic with a new README, carrying the open listing-yield and mux-consumer-clock children over from the deleted epic.
  • Relinked the root flake rule in quest/README.md to test-flakes-3, "planned anew once it completes".
  • Reworded a reference in mux-consumer-clock.md to say "the finished flakes epic". No test-flakes-2 references remain.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit f75f4bb Nov 15, 2026
10 checks passed
@kixelated
kixelated deleted the quest-complete/test-flakes-2 branch November 15, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant