Skip to content

chore(smoke): refresh the toolchain and matching Playwright pin - #8703

Merged
moq-bot[bot] merged 2 commits into
mainfrom
smoke/toolchain-update
Nov 14, 2026
Merged

moq-bot[bot] merged 2 commits into
mainfrom
smoke/toolchain-update

Conversation

@moq-bot

@moq-bot moq-bot Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The published-package smoke clients need a current toolchain whose Chromium matches npm Playwright.

Approach

Refresh smoke's flake lock and derive its exact npm Playwright pin from PLAYWRIGHT_VERSION in the same change. The existing browser smoke lane consumes both pins and validates freshness.

Impact

  • Public API and wire: none. Only the smoke test toolchain changes.

Alternatives

A lock-only update leaves the npm pin behind and fails freshness.

Follow-ups

None. This workflow does not enqueue or merge updates.

Decisions

  • ✅ Keep the lock-only diff (rejected: also bumping the npm pin): the refreshed nixpkgs still ships Playwright 1.64.1, so clients/js/package.json already matches and the updater correctly leaves it unchanged.
  • ✅ Do not fix the red Upstream Docker lane here (rejected: folding in the runner fix): it fails on main too and #8752 already fixes it.

Validation

  • just check-toolchain in test/smoke on the merged head: freshness ok (playwright 1.64.1 == toolchain 1.64.1), bun install, and a headless Chromium launch with the nix browser all passed.
  • just check passed.
  • Smoke dispatched on this branch (run 43638160702): browser, Cloudflare, Moxygen, external relay, token, and the package-channel jobs passed. Only Upstream Docker interoperability failed (runner.py incomplete runner coverage), the same failure as the last scheduled and push runs on main, which #8752 fixes and its own dispatch run passed.

Models

Size: XS
Implementer: Claude Code, claude-sonnet-5-5, unknown effort (iterate, XS)

(Written by Claude Sonnet 5.5)

Review

Rewritten by quest review after each round.

  • Head: 6977b82

  • Base: origin/main at 51611bd

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1dbd7-f661-7610-928a-be1400f4071a, round 1

  • Score: 10/10, The scoped diff changes only test/smoke/flake.lock, which the repository review rules exclude from findings, so no reportable defects block landing.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

@kixelated
kixelated marked this pull request as ready for review November 14, 2026 20:55
@kixelated
kixelated enabled auto-merge November 14, 2026 20:56

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the full diff, which touches only test/smoke/flake.lock.

  • flake-utils bump: refreshes the locked rev and hash.
  • nixpkgs bump: moves to a newer rev. The PR says it still ships Playwright 1.64.1, so clients/js/package.json needs no change.
  • systems bump: refreshes the locked rev and hash.

I did not re-run the validation. The PR reports just check-toolchain and the smoke dispatch passing, apart from the Upstream Docker lane, which also fails on main.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit d4b46ee Nov 14, 2026
18 of 19 checks passed
@moq-bot
moq-bot Bot deleted the smoke/toolchain-update branch November 14, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant