[kixelated]

Summary

Settles quest/m1/live-history-demand with a test. The demand was already right, so this PR deletes the quest.

The [{}] demand seen during #8643 is not an open live range. {} with no start means "from the oldest group". JS subscriptionDefaults gives a reader with no ranges the range [{}], and Rust's Subscription::default gives it Range::oldest(). union collapses the pair to [{}], which reaches below any history floor, and rangesStart reports no absolute floor (oldest) to the wire.

The new test in js/net/src/track.test.ts pins:

• a history reader [5, 9) beside a reader with no ranges: the demand is [{}], with no absolute start;
• a history reader [5, 9) beside an explicit LIVE reader: the demand keeps both ranges.

Decisions

• I treated "no ranges = oldest" as intended, because it matches Rust. So the outcome is a test and no fix.

Impact

Tests only. No change to the public API or the wire.

Caused by

None: no bug.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Opus 5.5)

Review

Rewritten by quest review after each round.

• Head: eca3fd7

• Base: origin/main at 98e54e7

• Reviewer: Codex, gpt-6.1-sol, medium effort

• Session: 01a1d7a0-3fce-7983-b636-3e6c1b0619d6, round 1

• Score: 10/10, The new test matches existing range-defaulting and union behavior, and deleting the resolved quest is consistent with its goal; source inspection found no actionable defects, and tests were not run as instructed.

• Rounds: 1; findings 0: fixed 0, refuted 0, open 0

• Findings: none

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 993a1e47-111c-4aab-8a52-f5c215a1904f

Commits

Reviewing files that changed from the base of the PR and between 5e56ba4 and eca3fd7.

Files selected for processing: 2

• js/net/src/track.test.ts
• quest/m1/live-history-demand.md

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[pullfrog]

✅ No new issues found.

Reviewed changes: the full diff (2 files). I checked the test's expectations against subscriptionDefaults, union and rangesStart in js/net/src.

• New test in js/net/src/track.test.ts: pins that a reader with no ranges beside a history reader gives the demand [{}] with no absolute floor, and that an explicit LIVE reader keeps both ranges. Both match the code (ranges: [{}] default, union collapsing to [{}], rangesStart returning undefined).
• Deleted quest quest/m1/live-history-demand.md: the quest is settled because the test shows the demand was already correct.

  ^{｜ View workflow run ｜ Using claude-sonnet-5-5 ｜ 𝕏}