Repository navigation
test(interop): record ten complete go to python matrix runs - #8633
Merged
Merged
Conversation
kixelated
marked this pull request as ready for review
November 13, 2026 17:57
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — the full diff, three quest documents, no code.
- Interop epic: rewrites the
go -> pythonentry to record ten completed matrices with no reproduction, and links #8611. - Test flakes epic: replaces the "added" note with the investigation outcome and says no fix is claimed.
- Quest removal: deletes
quest/m0/test-flakes-2/interop-go-python.md. Nothing in the checkout still links to it.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The scheduled run 43260674067 failed
go -> pythonwithaudio gap after 648 samples. Focused runs had not reproduced it.Approach
Complete the maintainer-authorized repeated-run investigation in the normal dev shell. Retire the separate quest and leave the results in both parent epics. No runtime fix is claimed: Go-to-Python held across ten completed full matrices, which does not rule out a rarer failure.
Read moq-dev/moq#8531 first: its short hole wait reaches the Python decoder. The failing artifact contains six contiguous PCM frames totaling 648 samples, one 20 ms batch minus Opus pre-skip. The original logs do not establish which skip condition fired. moq-dev/moq#8611 has since reproduced a CPU-starvation skip in the same consumer and owns its Rust/JS fix and client diagnostics. This PR changes no clients or playback policy.
Validation
Command:
HARNESS_KEEP=1 HARNESS_RUNS="$PWD/.tmp/full-runs" RUST_LOG=warn,moq_mux=debug quest gate nix develop --command just test interop --all(the loop ran this recipe in one gated dev-shell invocation).All JS clients built and participated. Ten matrices completed: Go-to-Python passed in every one, including its finished-media check. Nine matrices passed entirely. The ten retained run directories, under
.tmp/full-runs/, are:Attempt 4 failed browser-publisher cells after its session timed out, plus Rust and C swapped-tone cells. Those logs remain retained; it is not counted as a green matrix. Attempts 5, 6, 7, and 11 never reached the matrix: mbx reported waiting for machine-wide scheduler capacity inside nextest's 60 s timeout. Attempt 9 was interrupted after Go-to-Python passed and is excluded from the ten completed matrices.
bun run checkpass insidenix develop.python3 sh/gh/rustc-cost.test.py: all four tests pass on the PR and in a separate unchangedorigin/maincheckout at6aa4f9c1cad482aa86adcf3cf26bd7779697a01a, inside the dev shell. Both test files are identical to the base. Open PRs were searched by text and changed files; no rustc-cost fix was found. The earlier plain-shell failures came from the session's BASH_ENV snapshot replacing subprocess PATH entries, including the test's fake perf; no tests were changed or skipped.quest check --base origin/main: 504 documents pass.quest gate nix develop --command just ci: passed (124 s), including all rustc-cost tests.Impact
Alternatives
Changing a delay or retrying a failing cell into a pass would hide the failure. No delay, timeout, assertion, or retry policy changed. All attempts, including failed and incomplete ones, are reported above.
Decisions
Caused by
Undetermined for the original Go-to-Python failure. #8531 is a lead; #8611 confirms its media-age skip problem for another cell.
Follow-ups
No new quest. moq-dev/moq#8611 owns the common consumer skip; the existing Interop epic retains the matrix-wide outcome.
Review
Skipped on head 9d131e8: the maintainer chose Pullfrog's online review over the local OpenCode pass, which is out of credit.
Models
Size: S
Implementer: Codex, gpt-6.1-sol, medium effort (iterate, S)
(Written by GPT-6.1 Sol with medium)