Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,8 @@ jobs:
# The largest models get a runner each, and the route model's two
# largest configs (about 45 and 70 minutes on 4 workers) one per
# config; the `route` and `rest` legs take every other config, so a
# new one is checked without editing this list.
# new one is checked without editing this list. sh/gh/nightly.test.py
# fails on a path that no longer exists.
include:
- name: resume
paths: rs/moq-net/verify/resume
Expand Down
5 changes: 3 additions & 2 deletions rs/moq-net/verify/failover/EndedRelay.cfg
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
\* Open finding: NoSkipWhileHeld. A relay whose track ended cannot move a fetch
\* off a route that dies (see the verify-failover skill).
\* FailoverChain.cfg with B also routing through A, so the route can move at
\* the middle hop. Fails on the open finding in the verify-failover skill: a
\* relay whose track ended cannot move a fetch off a route that dies.
\* the middle hop.
CONSTANTS
G = 2
F = 2
Expand Down
11 changes: 11 additions & 0 deletions sh/gh/nightly.test.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,17 @@ def test_dev_shell_jobs_trust_the_nix_cache(self):
if "nix develop" in job and "runs-on: [self-hosted" not in job:
self.assertIn("uses: ./.github/actions/nix", job, job.splitlines()[0])

def test_every_tla_leg_path_exists(self):
# A leg naming a deleted config checks nothing and fails Nightly; an
# exclusion naming one silently stops excluding.
workflow = (ROOT / ".github/workflows/nightly.yml").read_text()
job = re.search(r"^ tla:\n(.*?)^ \S", workflow, re.M | re.S)
self.assertIsNotNone(job)
paths = [p for line in re.findall(r"^ +paths: (.+)$", job[1], re.M) for p in line.strip('"').split()]
self.assertTrue(paths)
missing = [p for p in paths if not (ROOT / p.removeprefix(":!")).exists()]
self.assertEqual(missing, [], "TLA+ matrix paths that no longer exist")

def test_benchmark_tests_stay_out_of_cargo_bench(self):
workflow = (ROOT / ".github/workflows/nightly.yml").read_text()
for group in RUST_TEST_GROUPS:
Expand Down