Skip to content

chore(verify): drop the statechart views no skill draws - #8567

Merged
kixelated merged 1 commit into
mainfrom
chore/drop-statechart-views
Nov 12, 2026
Merged

kixelated merged 1 commit into
mainfrom
chore/drop-statechart-views

Conversation

@kixelated

@kixelated kixelated commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Eight *.view.ts files and rs/moq-net/verify/resume/Chart.cfg existed only to feed /statechart, a diagram skill from a third-party Cursor plugin (pstack) that is not installed anywhere now, so nothing reads them. The skill only draws a model or a counterexample; TLC checks every rule without it. This deletes them, along with ResumeReader.tla's Story definition that only Chart.cfg used, and the chart wording in the verify READMEs, Room.cfg, and the verify-resume skill.

The models, their configs, and every rule they check are unchanged.

Decisions

  • ✅ Drop it and delete the views (rejected: reinstalling the plugin and keeping 682 lines of labels for it). Decided 2026-11-12 by the maintainer; suggested by #8539.

Impact

Public API: none. Wire: none. No model or checked rule changes.

Validation

  • nix develop -c quest gate just check passes.
  • just test tla rs/moq-net/verify/resume passes, so ResumeReader.tla still parses and checks without Story.

Follow-ups

None.

Models

Size: XS
Implementer: Claude Code, claude-fable-5-2, high effort

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: b2b5a97

  • Base: origin/main at 8c8f0ef

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1d095-e6b8-7780-8de7-deb62675ed15, round 1

  • Score: 10/10, This is a scoped cleanup with no remaining consumers of the removed views or chart-only configuration, retained verification coverage, and no identified behavioral regression.

  • Findings: none

Eight `*.view.ts` files, `Chart.cfg`, and its `Story` definition existed
only for a `/statechart` skill that is not in this repository or its history.

Co-Authored-By: Claude <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 12, 2026 16:28
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6cbe2bef-d269-4e6e-a098-461037553834
Commits

Reviewing files that changed from the base of the PR and between 8c8f0ef and b2b5a97.

Files selected for processing: 15

  • .claude/skills/verify-resume/SKILL.md
  • js/publish/verify/Publish.view.ts
  • js/publish/verify/README.md
  • js/room/verify/README.md
  • js/room/verify/Room.cfg
  • js/room/verify/Room.view.ts
  • js/watch/verify/Failover.view.ts
  • js/watch/verify/README.md
  • js/watch/verify/Watch.view.ts
  • rs/moq-net/verify/reconnect/Handover.view.ts
  • rs/moq-net/verify/resume/Chart.cfg
  • rs/moq-net/verify/resume/ResumeReader.tla
  • rs/moq-net/verify/resume/ResumeReader.view.ts
  • rs/moq-net/verify/route/RouteHandoff.view.ts
  • rs/moq-net/verify/subscribe/SubscribeAccounting.view.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one stale reference worth a two-line tidy.

Reviewed changes

Read the complete diff and checked every removal against the repo for remaining consumers: no hits for .view.ts, statechart, Chart.cfg, or the word Story outside node_modules, and git ls-files '*.view.ts' is now empty.

  • Eight statechart views deleted — Publish, Room, Watch, Failover, Handover, ResumeReader, RouteHandoff, and SubscribeAccounting lost their *.view.ts label files, whose only consumer was the uninstalled pstack /statechart skill.
  • Chart.cfg and Story dropped — the story config and the CONSTRAINT Story definition it fed are gone; ResumeReader.tla now goes from CopiesBounded straight to TypeOK, and ResumeReader.cfg / ThreeRoutes.cfg still check every invariant over larger bounds, so no reachable-violation coverage was lost (a CONSTRAINT only prunes the state space).
  • Prose rewritten — the three JS verify READMEs, Room.cfg's comment, and verify-resume/SKILL.md keep the facts the charts used to carry (badge text, what viewers see) while dropping the drawing instructions.
  • CI unaffected — sh/tla.sh discovers configs by glob and the nightly tla matrix names the rs/moq-net/verify/resume directory, not Chart.cfg, so that leg simply runs two configs now.

ℹ️ Two quest plans still point at the deleted diagrams

quest/m3/net-redirect-fallback.md tells the next agent to "update the Failover chart" as part of its fix, and two quest files cite charting as the discovery method. Those files are not in this diff, so the references will dangle once it lands.

Technical details
# Stale chart references left behind

## Affected sites
- quest/m3/net-redirect-fallback.md:23-24 — the Plan's recommended fix ends "Flip the residual test and update the Failover chart."; `js/watch/verify/Failover.view.ts` is deleted here, so the step names an artifact that no longer exists.
- quest/m3/net-redirect-fallback.md:11 — provenance: "Found 2026-11-10 by the failover chart".
- quest/m3/room-keep-through-blip.md:12 — provenance: "Found 2026-11-10 while charting the room flow".

## Required outcome
- The live instruction should either drop the chart clause or point at the `Failover.cfg` rule it actually means, so a quest run does not chase a deleted file.

## Open questions for the human
- Whether the two provenance mentions are worth rewriting for accuracy or left as history of how the findings were made.

Pullfrog  | Fix it ➔ | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit d9487ff Nov 12, 2026
7 checks passed
@kixelated
kixelated deleted the chore/drop-statechart-views branch November 12, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant