Repository navigation
chore(verify): drop the statechart views no skill draws - #8567
Conversation
Eight `*.view.ts` files, `Chart.cfg`, and its `Story` definition existed only for a `/statechart` skill that is not in this repository or its history. Co-Authored-By: Claude <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
ℹ️ No critical issues — one stale reference worth a two-line tidy.
Reviewed changes
Read the complete diff and checked every removal against the repo for remaining consumers: no hits for .view.ts, statechart, Chart.cfg, or the word Story outside node_modules, and git ls-files '*.view.ts' is now empty.
- Eight statechart views deleted —
Publish,Room,Watch,Failover,Handover,ResumeReader,RouteHandoff, andSubscribeAccountinglost their*.view.tslabel files, whose only consumer was the uninstalledpstack/statechartskill. Chart.cfgandStorydropped — the story config and theCONSTRAINT Storydefinition it fed are gone;ResumeReader.tlanow goes fromCopiesBoundedstraight toTypeOK, andResumeReader.cfg/ThreeRoutes.cfgstill check every invariant over larger bounds, so no reachable-violation coverage was lost (aCONSTRAINTonly prunes the state space).- Prose rewritten — the three JS verify READMEs,
Room.cfg's comment, andverify-resume/SKILL.mdkeep the facts the charts used to carry (badge text, what viewers see) while dropping the drawing instructions. - CI unaffected —
sh/tla.shdiscovers configs by glob and the nightlytlamatrix names thers/moq-net/verify/resumedirectory, notChart.cfg, so that leg simply runs two configs now.
ℹ️ Two quest plans still point at the deleted diagrams
quest/m3/net-redirect-fallback.md tells the next agent to "update the Failover chart" as part of its fix, and two quest files cite charting as the discovery method. Those files are not in this diff, so the references will dangle once it lands.
Technical details
# Stale chart references left behind
## Affected sites
- quest/m3/net-redirect-fallback.md:23-24 — the Plan's recommended fix ends "Flip the residual test and update the Failover chart."; `js/watch/verify/Failover.view.ts` is deleted here, so the step names an artifact that no longer exists.
- quest/m3/net-redirect-fallback.md:11 — provenance: "Found 2026-11-10 by the failover chart".
- quest/m3/room-keep-through-blip.md:12 — provenance: "Found 2026-11-10 while charting the room flow".
## Required outcome
- The live instruction should either drop the chart clause or point at the `Failover.cfg` rule it actually means, so a quest run does not chase a deleted file.
## Open questions for the human
- Whether the two provenance mentions are worth rewriting for accuracy or left as history of how the findings were made.deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Summary
Eight
*.view.tsfiles andrs/moq-net/verify/resume/Chart.cfgexisted only to feed/statechart, a diagram skill from a third-party Cursor plugin (pstack) that is not installed anywhere now, so nothing reads them. The skill only draws a model or a counterexample; TLC checks every rule without it. This deletes them, along withResumeReader.tla'sStorydefinition that onlyChart.cfgused, and the chart wording in the verify READMEs,Room.cfg, and theverify-resumeskill.The models, their configs, and every rule they check are unchanged.
Decisions
Impact
Public API: none. Wire: none. No model or checked rule changes.
Validation
nix develop -c quest gate just checkpasses.just test tla rs/moq-net/verify/resumepasses, soResumeReader.tlastill parses and checks withoutStory.Follow-ups
None.
Models
Size: XS
Implementer: Claude Code, claude-fable-5-2, high effort
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: b2b5a97
Base: origin/main at 8c8f0ef
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1d095-e6b8-7780-8de7-deb62675ed15, round 1Score: 10/10,
This is a scoped cleanup with no remaining consumers of the removed views or chart-only configuration, retained verification coverage, and no identified behavioral regression.Findings: none