Skip to content

Nightly's macOS platform job passes - #8552

Merged
kixelated merged 2 commits into
mainfrom
quest/m0/nightly/macos
Nov 12, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m0/nightly/macos

Conversation

@kixelated

@kixelated kixelated commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/nightly/macos.md. The goal is met, so no code changes.

Evidence: all six scheduled Nightly runs on main since the capture fix (#7976) passed platform / macOS: 42236107954, 42377867523, 42487375545, 42659882487, 42842827718, 43041909115. moq-tokio::integration broadcast::broadcast_websocket_uses_newest_version passed in 0.018–0.045 s in each run. The timeout has not come back, so per the Plan there is nothing to reproduce.

Choices made without asking:

  • I treated six nightly runs (Nov 6–11) as the "week of scheduled runs". Today's run hasn't happened yet.
  • The quest/m0/nightly/ epic has no children left, so its README now carries a size: [M]. Its remaining work is getting the whole Nightly green, which still fails on other jobs.

Public API: none. Wire: none.

Follow-ups

None.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Skipped: too trivial to review. The diff deletes one finished quest file and adds a [M] size to the epic README, which quest check requires. Head f842340.

kixelated and others added 2 commits November 12, 2026 01:25
Quest-Claim: 39e1b33fb5d0159d
Six scheduled runs since #7976 (Nov 6-11) pass platform / macOS, with
broadcast_websocket_uses_newest_version passing in 0.02-0.05 s each.
The nightly epic's README now carries a size as its last child is gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 12, 2026 09:25
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The nightly README heading now includes the [M] prefix. The macOS Nightly tracking document was deleted.

Merge Risk: Minimal · up to f8423

This documentation-only change updates the Nightly README heading and removes the macOS tracking document. It does not affect runtime behavior, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states that the Nightly macOS platform job passes, which matches the main change: the macOS quest tracking document is closed after six scheduled Nightly runs on main passed the macOS job. T…
Description check Passed The description states that the author finished quest/m0/nightly/macos.md and cites six scheduled Nightly runs on main that passed platform / macOS. It also explains the added [M] size to the Nightly …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states that the Nightly macOS platform job passes, which matches the main change: the macOS quest tracking document is closed after six scheduled Nightly runs on main passed the macOS job. The title is specific and short, and it is related to the changeset.

Full details: Description check

Explanation

The description states that the author finished quest/m0/nightly/macos.md and cites six scheduled Nightly runs on main that passed platform / macOS. It also explains the added [M] size to the Nightly epic README and notes that no code changes were made. This directly describes the changeset.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d64ce27d-4c23-462e-bad7-dd6e4eb91ff9
Commits

Reviewing files that changed from the base of the PR and between 4265dc5 and f842340.

Files selected for processing: 2

  • quest/m0/nightly/README.md
  • quest/m0/nightly/macos.md
Files with no reviewable changes: 1

  • quest/m0/nightly/macos.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — quest bookkeeping only; I re-checked the PR's evidence against Actions rather than taking it on trust.

  • quest/m0/nightly/macos.md deleted — the quest's goal is marked met, and no repo file links the file or the nightly/macos slug.
  • quest/m0/nightly/README.md gains [M] — with the last child gone the epic carries its own size, matching quest/m0/interop-green/README.md ([XS]); the Quest check passes on this head.

Evidence verified

  • All six scheduled Nightly runs cited (42236107954 through 43041909115) have platform / macOS at success. Their run-level conclusion is failure from other jobs, which is what the epic README already says.
  • #7976 merged 2026-11-06T10:05Z, ahead of the first cited run (14:41Z), so the window really starts after the capture fix.
  • just rs macos-test runs just rs test -p kio -p hang -p moq-tokio -p moq-sock, and mod broadcast; is registered in rs/moq-tokio/tests/integration/main.rs, so broadcast_websocket_uses_newest_version is exercised on macOS. The per-run 0.018–0.045 s timings were not re-derived from job logs.

One note, not a finding: six scheduled runs is six days rather than a full week, and the author disclosed that reading in the body.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 0567df7 Nov 12, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m0/nightly/macos branch November 12, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant